Fix QQQ workspace lifetime and reduce packing memory - #3029
Open
yujiongzhang wants to merge 4 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
During QQQ quantization of large MoE models, CPU memory and swap usage may increase after each module or layer. The previous implementation retained QQQ quantization workspaces until later cleanup and created multiple full-size temporary tensors and NumPy arrays during weight packing.
This change releases the quantization workspace as soon as it is no longer needed and limits packing temporary memory to a fixed-size working set.
Implementation
QQQProcessornow callsQQQ.free()in afinallyblock after each module quantization.QQQLinear.pack()now: