Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\n\nFixes duplicate child statistic updates in StatsProvider when more than one stats listener is registered.\n\nChild-stat recursion previously ran inside the listener loop. With N registered listeners, each child was recursively processed N times and broadcast to all N listeners, producing N² child update events instead of N.\n\n## Changes\n\n- Move child-stat recursion outside the listener iteration.\n- Preserve parent and aggregate-stat notification behavior.\n- Add a regression test with two listeners and a nested child statistic.\n\n## Validation\n\n-
pm run check-types\n-
pm run lint (one pre-existing warning)\n-
pm run test -- --run (35 passed)\n-
pm run build:all\n\n## Before / after\n\nWith two listeners and one child statistic, the previous implementation delivered four child events. This change delivers two: one per listener.