Add Ollama model artifact attestation - #1
Draft
s33thr33p10 wants to merge 1 commit into
Draft
s33thr33p10 wants to merge 1 commit into
s33thr33p10 wants to merge 1 commit into
Conversation
Signed-off-by: S33Thr33P10 <273638375+s33thr33p10@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is the PAIR-side counterpart to merged
MrNiceAI/ai-studioPR NVIDIA#81. It is intentionally limited to the Ollama proxy. It does not install or activate PAIR, alter models or routes, or open an upstream NVIDIA pull request.Exact scope
Five repository paths changed from NVIDIA base
13b68115fa2c9c1d94f1ead1358f8d5a527cfecf:docs/architecture.mdxservices/ollama-proxy/README.mdservices/ollama-proxy/artifact_attestation_test.goservices/ollama-proxy/proxy.goservices/versions.jsonSigned C3PO head:
ee17499ed95eb5cff142a1c799701ba2477c6a1cFinal exact-diff SHA-256:
e9a0f9c47c5285e502daab9346c0cfd652246d436369d0372e1a01f0be172293Independent review and resolutions
One ephemeral read-only review used
gpt-5.6-terrawith high reasoning against the authorized initial five-path diff, SHA-256fdef3d7a480330c3db80a344d5970e221c9c3e312501320becadec977da309ba.All five findings were resolved within the same five paths:
ReverseProxycopies trailers./api/tagsstill gates candidates before dispatch, while a second/api/psread verifies the exact digest from Ollama's scheduler-owned loadedModelbefore any response byte commits. A stale, absent, ambiguous or unavailable live record fails over or fails closed.Regression tests cover selection, manual pinning, failover, mismatch and inventory failure, malformed/duplicate/trailer inputs, redirect refusal, loaded-digest changes, bounded concurrency, engine header/trailer replacement, and unbound-request compatibility.
Validation
Windows isolated Go container (
golang:1.26.5-bookworm):go test ./...go test -race ./...go vet ./...git diff --checkPinned Apple Silicon Mac under the C3PO account with checksum-verified official Go
1.25.14:TestAliasSelfTargetMatchesBoundLoopbackAddressNotPortAloneexcluded because macOS rejects that test's127.0.0.2bindgo vet ./...go build ./...The signed commit contains an SSH signature and the required DCO
Signed-off-bytrailer. Hosted validation is supplied separately from the fork's trustedmainbranch and must pass before this Draft is marked Ready.