Skip to content

Virtualize all viewer modes - #1440

Open
dnass wants to merge 12 commits into
mainfrom
1425-virtualize-other-viewer-modes
Open

dnass wants to merge 12 commits into
mainfrom
1425-virtualize-other-viewer-modes

Conversation

@dnass

@dnass dnass commented Oct 23, 2026

Copy link
Copy Markdown
Contributor

Closes #1425.

Adds virtualization for all remaining viewer modes: Text, Pages, Notes, and Results. Text mode intentionally renders 200 pages to preserve the ability to use browser search across the document. Other views use Virtua's defaults.

@dnass
dnass requested review from allanlasser and eyeseast October 23, 2026 13:58
@github-actions

Copy link
Copy Markdown

Preview deployed: https://preview-1440.staging.documentcloud.org

@github-actions

github-actions Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 53.62% 4275 / 7972
🔵 Statements 52.2% 5024 / 9624
🔵 Functions 47.33% 1616 / 3414
🔵 Branches 50.49% 2202 / 4361
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
src/lib/components/toolbars/PaginationToolbar.svelte 80.95% 72.72% 75% 77.08% 77-80, 92, 97-88, 119, 133
src/lib/components/viewer/Grid.svelte 96.55% 55.55% 92.85% 95.45% 74
src/lib/components/viewer/Notes.svelte 100% 100% 100% 100%
src/lib/components/viewer/PDF.svelte 72.05% 57.89% 72.72% 61.22% 33-42, 57, 60-66, 72, 80-89, 133-137
src/lib/components/viewer/Search.svelte 95.65% 66.66% 96% 96.42% 48, 50
src/lib/components/viewer/Text.svelte 92% 50% 100% 90.47% 44-45
src/lib/components/viewer/Virtualizer.svelte 100% 100% 100% 100%
src/lib/components/viewer/stories/ScrollContainer.svelte 0% 0% 0% 0%
src/lib/state/viewer.svelte.ts 98.64% 97.14% 100% 98.41% 29-32
src/lib/utils/scroll.ts 82.69% 68.75% 92.3% 84.44% 37, 42, 48-49, 90, 109-111, 115
Generated in workflow #1438 for commit d8af120 by the Vitest Coverage Report Action

@dnass

dnass commented Oct 26, 2026

Copy link
Copy Markdown
Contributor Author

@eyeseast I fixed the Chromatic issue here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Virtualize other Viewer modes: Text, Grid and Notes

2 participants