Repository navigation
Remove v1 pagination logic [staging] - #516
Open
duckduckgrayduck wants to merge 1 commit into
Open
duckduckgrayduck wants to merge 1 commit into
duckduckgrayduck wants to merge 1 commit into
Conversation
…, leaving versioning in place
eyeseast
approved these changes
Oct 27, 2026
duckduckgrayduck
force-pushed
the
staging
branch
from
October 28, 2026 20:16
26c8284 to
6807b35
Compare
mitchelljkotler
approved these changes
Oct 28, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: #490
Remove API v1 page-number pagination
v2 cursor pagination has been the default in production for a long time, and v1 is deprecated. This removes the v1 pagination code, but keeps the versioning infrastructure in case we need a v3.
ALLOWED_VERSIONS is now ["2.0"], so ?version=1.0 returns a 404. QueryParameterVersioning is kept for a future v3.
Removed PageNumberPagination, VersionedPagination and VersionedCountPagination. CursorPagination is now the default, and ProjectMembershipViewSet uses CursorCountPagination directly.
Solr search no longer reads version itself. It always uses cursor pagination, and the page-number path (_paginate, _paginate_page and the page branch in _format_response) is removed.
Removed the AUTH_PAGE_LIMIT/ANON_PAGE_LIMIT settings, which only v1 used. After deploying, we should remove those env vars on Heroku too.
The search ValueError handler now returns "code": "invalid_query" instead of "max_page", since it now only catches luqum ParseErrors. The API docs now say v1 has been removed.