Skip to content

Nginx config changes [production] #524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
duckduckgrayduck merged 4 commits into from
Oct 28, 2026
Merged

Nginx config changes [production] #524

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
adf4dd7
Add a size cap to addon_events_patches
duckduckgrayduck Oct 2, 2026
ffe30c0
Return a 429 when someone surpasses the rate limit, because nginx def…
duckduckgrayduck Oct 2, 2026
69bd5bf
Set sitewide 25MB cap, bump keepalive_timeout to 95 to stop getting H…
duckduckgrayduck Oct 26, 2026
9cdc484
Inline the cors preflight to shrink the PR and restore its old setup
duckduckgrayduck Oct 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 33 additions & 5 deletions config/nginx.conf.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ events {
http {

map_hash_bucket_size <%= ENV.fetch("NGINX_HASH_BUCKET_SIZE", 64) %>;

gzip on;
gzip_http_version 1.0;
gzip_comp_level 5;
Expand Down Expand Up @@ -81,7 +80,7 @@ http {
}

limit_req_zone $limit_key zone=one:10m rate=10r/s;

limit_req_status 429;
log_format l2met 'measure#nginx.service=$request_time request_id=$http_x_request_id';
log_format compression '$remote_addr - $remote_user [$time_local] '
'"$request" $status $bytes_sent '
Expand All @@ -95,7 +94,8 @@ http {

#Must read the body in 5 seconds.
client_body_timeout 5;
client_max_body_size 4G;
# Uploads go direct to S3 and Mailgun attachments are fetched by URL; 25MB covers GitHub webhooks
client_max_body_size <%= ENV.fetch("NGINX_MAX_BODY_MB", 25) %>m;

upstream app_server {
server unix:/tmp/nginx.socket fail_timeout=0;
Expand Down Expand Up @@ -182,18 +182,46 @@ http {
<% end %>
}

# Headers for nginx's own 429s only; responses from Django set their own
map "$upstream_status:$status" $retry_after {
default "";
":429" 1;
}

map "$upstream_status:$status" $limit_cors_origin {
default "";
":429" $cors_origin_header;
}

map "$upstream_status:$status" $limit_cors_cred {
default "";
":429" $cors_cred;
}

map "$upstream_status:$status" $limit_cors_expose {
default "";
":429" "Retry-After";
}

server {

listen <%= ENV["PORT"] %>;
server_name _;
keepalive_timeout 5;
keepalive_timeout 95;
limit_req zone=one burst=20 nodelay;

add_header Retry-After $retry_after always;
add_header Access-Control-Allow-Origin $limit_cors_origin always;
add_header Access-Control-Allow-Credentials $limit_cors_cred always;
add_header Access-Control-Expose-Headers $limit_cors_expose always;

if ($http_host ~ "\.$" ){
rewrite ^(.*) $scheme://$host$1 permanent;
}

location / {

# Answer CORS preflights directly from nginx
if ($request_method = 'OPTIONS' ) {
add_header "Access-Control-Allow-Origin" $cors_origin_header always;
add_header "Access-Control-Allow-Credentials" $cors_cred;
Expand All @@ -211,4 +239,4 @@ http {

}

}
}
Loading