Repository navigation
Conversation
The lint CI job runs `pre-commit run --all-files`, which was failing on main itself with 16 markdownlint errors and 4 black reformats inherited from the initial veda-data import. This blocked every open dataset PR. - README.md: blank lines around headings, demote the second h1 to h2, add a language to the bare fence, drop trailing punctuation and fix the heading increment, collapse doubled blank lines - .markdownlint-cli2.jsonc: scope MD024 to siblings; `archive` is a real folder name under more than one parent section - add missing trailing newlines to requirements.in, the three scripts and tests/test_collections.py `pre-commit run --all-files` now exits 0 and is idempotent.
fix: optional transfer configuration
The lint job runs pre-commit on all files, and pre-existing issues on main caused every PR's lint check to fail regardless of its diff. - README.md: markdownlint fixes (blank lines around headings, single H1, fence language, heading increment, no trailing colon, rename duplicate 'archive' heading, trailing newline, trailing whitespace) - requirements.in: trailing newline (file-contents-sorter) - black: trailing newline in generate_mdx.py, promote_collection.py, test_collections.py
…mmit-lint chore: fix pre-commit lint failures blocking CI
…lint Fix pre-commit lint failures on main
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/NASA-IMPACT/veda-architecture/issues/849
Based on changes from NASA-IMPACT/veda-data#454