Repository navigation
fix: optional transfer - #9
Merged
Merged
Conversation
jjfrench
commented
Sep 2, 2026
sandrahoang686
previously requested changes
Sep 2, 2026
jjfrench
commented
Sep 2, 2026
| if transfer is not None and not isinstance(transfer, bool): | ||
| raise ValueError( | ||
| f"Invalid value for 'transfer': {transfer!r}. Must be a boolean." | ||
| ) |
There was a problem hiding this comment.
cool, I think this can also be validated on the UI side too 🤔 . Show error when value is anything other than bool if exists. Might be able to work on that super quick...
sandrahoang686
requested review from
a team and
sandrahoang686
and removed request for
sandrahoang686
September 2, 2026 17:23
|
Sorry, dont mind me ^ .. i'm trying to remove my requested changes and was trying to figure it out 😅 |
jjfrench
dismissed
sandrahoang686’s stale review
September 2, 2026 20:08
Resolved the requested change but GitHub is still flagging it
botanical
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description