Repository navigation
algorithm-catalog: end date is optional (blank = ongoing event) - #252
Merged
Merged
Conversation
A blank end date was a hard error in rules.ts and validate_data.py, which
blocked filing an event that is still underway; the Disasters Portal itself
records only a startDate. Now only a malformed or out-of-order end is an error.
- Missing end reads as ongoing ("9 Oct 2026 – ongoing") and still matches any
later Events date filter (overlaps() treated "" as already ended).
- The request file omits end instead of writing ""; the import no longer
invents end = start (Hurricane Isaias).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #250. This commit was pushed after #250 had already merged, so it never reached
main.What
A blank end date used to be a hard error ("End date is required.") in both
rules.tsandvalidate_data.py. That blocked filing an event that's still underway. The Disasters Portal itself records only astartDate.overlaps()used to treat""as already ended, which silently hid them.endis omitted rather than written as"".end = start, so Hurricane Isaias is now ongoing.Verified
validate_data.pyandrules_parity_test.pypass, as donpm run typecheckandnpm run build.scripts/e2e.mjspasses 33/33 in Chromium. It includes three new checks:endkey.