Repository navigation
fix: replace vulnerable xlsx dependency - #1990
Open
alexandroit wants to merge 1 commit into
Open
alexandroit wants to merge 1 commit into
alexandroit wants to merge 1 commit into
Conversation
👷 Deploy request for veda-ui pending review.Visit the deploys page to approve it
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Ticket: Not applicable
Description of Changes
Replaces
xlsx@^0.18.5with@stackline/xlsx@^1.0.6through an npm alias:The dependency key remains
xlsx, so the existing static and dynamic imports donot change. The regenerated Yarn lockfile now resolves the alias to
@stackline/xlsx@1.0.6and removes upstreamxlsx@0.18.5and its dependencychain.
This addresses the advisories affecting the previous release:
Disclosure: I maintain
@stackline/xlsx, an independent Apache-2.0SheetJS-compatible fork. It requires Node 20 or newer, which is within this
project's declared Node 24 runtime.
Notes & Questions About Changes
No application code or UI behavior changes. Both
import('xlsx')and theexisting type import continue to resolve through the same module name.
Validation / Testing
Validated locally with Node 24.19.0 and Yarn 1.22.22:
yarn install --frozen-lockfile --ignore-scriptsyarn test --runInBand --silent(20 suites, 164 tests, 1 snapshot)yarn ts-checkyarn lint(no errors; existing warnings remain)yarn buildlibxlsxfinding