Replace vertical bars in Exit and Overall output#161
Open
martialblog wants to merge 1 commit into
Open
Conversation
Member
Author
|
@RincewindsHat I'm not 100% sure about this one. It's quite opinionated, on the other hand, I don't have to sanitize the strings in all check plugins. What do you think? |
martialblog
commented
Jun 19, 2026
|
|
||
| for _, s := range output { | ||
| text.WriteString(" " + s) | ||
| text.WriteString(" " + strings.ReplaceAll(s, "|", " ")) |
Member
Author
There was a problem hiding this comment.
We cannot use the PerfdataSeparatorSymbol constant here, it would cause circular dependency.
I briefly though about moving the perfdata.go into the check package. That would also avoid having to use it like this perfdata.Perfdata and just be check.Perfdata
Member
Author
There was a problem hiding this comment.
@RincewindsHat thoughts? I think it would probably make sense
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes sure that any output does not contain vertical bars
|so that the output won't conflict with the perfdata separator.