Repository navigation
fix(stage-router): recognize Hermes compaction - #951
Conversation
Signed-off-by: Ryan Lempka <rlempka@nvidia.com>
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 10 remain after this review. WalkthroughCompaction detection now recognizes two Hermes summary headers in user and assistant text, in addition to the existing Claude Code marker. Tests cover matching cases and text that must not trigger detection. ChangesCompaction Detection
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~8 minutes Merge Risk: ⚪ Minimal · up to The pinned Hermes compaction summary matches the new detector, so the intended capable-model routing remains available. No actionable merge-blocking risk is established. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
A rabbit checks each line with care, Comment |
Stage already keeps compacted conversations on the capable model, but it did not recognize Hermes' compaction headers. This change recognizes Hermes' summary and resumed-task headers and applies the existing compaction override. Verified with real Hermes compaction through Switchyard using a scripted model endpoint: requests after compaction now stay on the capable model, while earlier routing stays unchanged. All local tests and checks pass.
Summary by CodeRabbit