Skip to content

fix: correct NoReturn annotations for normal-returning functions - #104

Draft
andrewwhitecdw wants to merge 1 commit into
NVIDIA:mainfrom
andrewwhitecdw:bugfix/bobber-ed9ee068
Draft

fix: correct NoReturn annotations for normal-returning functions#104
andrewwhitecdw wants to merge 1 commit into
NVIDIA:mainfrom
andrewwhitecdw:bugfix/bobber-ed9ee068

Conversation

@andrewwhitecdw

Copy link
Copy Markdown

Problem

fix: correct NoReturn annotations for normal-returning functions

Fix

Apply patch:

--- a/bobber/bobber.py
+++ b/bobber/bobber.py
@@ -28,6 +28,5 @@ from bobber.lib.analysis import parse_results
 from bobber.lib.system.file_handler import create_directory
 from bobber.lib.tests import run_tests
-from typing import NoReturn
 
 def unique_hosts(hosts: str) -> str:
@@ -257,7 +256,7 @@ def load_from_config(config_path: str) -> Namespace:
         return Namespace(**settings)
 
 
-def save_config(args: Namespace) -> NoReturn:
+def save_config(args: Namespace) -> None:
     """
     Save the settings as JSON.
@@ -339,7 +338,7 @@ def load_settings(args: Namespace) -> Namespace:
     return args
 
 
-def execute_command(args: Namespace, version: str) -> NoReturn:
+def execute_command(args: Namespace, version: str) -> None:
     """
     Execute a specific command from Bobber.
@@ -373,7 +372,7 @@ def execute_command(args: Namespace, version: str) -> NoReturn:
         run_tests.test_selector(args, version_underscore)
 
 
-def main() -> NoReturn:
+def main() -> None:
     """
     Launch a test with the Bobber framework.

Files changed

  • bobber/bobber.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant