fix(aggregate-results): wrong unit for 125k bandwidth JSON (+1 more)

[andrewwhitecdw]

This PR addresses 2 issues in bobber/lib/analysis/aggregate_results.py.

Fix 1

fix: wrong unit for 125k bandwidth JSON output

Fix: Replace:

            '125k_bandwidth': {
                'read': self._average_125k_read_bw(),
                'write': self._average_125k_write_bw(),
                'unit': 'operations/second',

with:

            '125k_bandwidth': {
                'read': self._average_125k_read_bw(),
                'write': self._average_125k_write_bw(),
                'unit': 'bytes/second',

Fix 2

fix: remove incorrect NoReturn return type from init

Fix: Apply patch:

--- a/bobber/lib/analysis/aggregate_results.py
+++ b/bobber/lib/analysis/aggregate_results.py
@@ -1,5 +1,4 @@
 # SPDX-License-Identifier: MIT
 from functools import wraps
-from typing import NoReturn
 
 def average_decorator(func: 'method') -> float:
@@ -115,7 +114,7 @@ class AggregateResults:
                 read_125k_bw_params: dict,
                 write_125k_bw_params: dict,
                 max_bw: dict,
                 bytes_sizes: dict,
                 dali_results: dict,
                 metadata: dict,
-                 systems: int) -> NoReturn:
+                 systems: int) -> None:
         self._read_bw = read_bw

Files changed

• bobber/lib/analysis/aggregate_results.py