Skip to content

Skip the orphan-reclaim test where the listener image is unresolvable #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
arcaven wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Skip the orphan-reclaim test where the listener image is unresolvable #47

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions services/nvpair-engine-manager/executor_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -691,6 +691,16 @@ func TestUninstallTerminatesRunningInstance(t *testing.T) {
t.Cleanup(func() { _ = cmd.Process.Kill() })
waitPortServing(t, port)

// Reclaiming a managed orphan needs the listener's executable path.
// procImage resolves it through /proc, so on a platform without /proc the
// image comes back empty, isOurEngineImage declines, and Uninstall refuses
// by design; see the procImage doc comment in proc_unix.go. Check the
// precondition rather than the platform, so this test starts running again
// on its own if the image ever becomes resolvable there.
if _, image, ok := pidOnPort(port); ok && image == "" {
t.Skipf("listener image is unresolvable on %s, so reclaim declines by design", runtime.GOOS)
}

m := testEngineManifest(bin)
key := runtime.GOOS + "/" + runtime.GOARCH
p := m.Platforms[key]
Expand Down