Skip to content

Persist manual nodes in the broker - #60

Open
sylvesterkaczmarek wants to merge 1 commit into
NVIDIA:developfrom
sylvesterkaczmarek:fix-broker-manual-node-persistence
Open

sylvesterkaczmarek wants to merge 1 commit into
NVIDIA:developfrom
sylvesterkaczmarek:fix-broker-manual-node-persistence

Conversation

@sylvesterkaczmarek

Copy link
Copy Markdown

Closes #58

Description

Move manual-node durability into nvpair-ui-broker so headless TUI/service nodes keep manual peers across broker and worker restarts. Successful add/remove operations update the existing configs/manual-nodes.json, and a restarted manual-nodes worker is repopulated automatically.

Scope

  • persist and replay manual-node entries in the broker
  • resolve stable discovered node IDs back to manual aliases for removal
  • remove Electron-owned persistence/replay logic
  • keep the existing JSON-RPC methods and on-disk file location
  • bump nvpair-ui-broker from 0.40.2 to 0.40.3

Validation

  • make check - passed, including 208 desktop unit tests
  • clean-user-data go test ./... in services/nvpair-ui-broker - passed
  • focused persistence/relay tests with -count=3 - passed
  • npm run dead-code:check - passed
  • make test-services reaches an existing lmstudio-proxy E2E port-selection failure; the same failing test reproduces on pristine main

Risk

The JSON-RPC surface is unchanged. Existing desktop manual-nodes.json entries remain readable because the broker takes ownership of the same file and schema.

Checklist

  • I have read the Contributing Guidelines.
  • Every commit is signed off, certifying the Developer Certificate of Origin.
  • New or existing tests cover the change.
  • Relevant documentation is updated.
  • I checked the diff, changed filenames, and commit messages for credentials, private data, internal URLs, internal issue identifiers, and generated artifacts.
  • I recorded the validation commands and results above.
  • I bumped the affected component in services/versions.json and described the user-visible change above.

Signed-off-by: Sylvester Kaczmarek <16242628+sylvesterkaczmarek@users.noreply.github.com>
@sherief-nv

Copy link
Copy Markdown
Collaborator

This makes sense. Moving MR against develop branch.

@sherief-nv
sherief-nv changed the base branch from main to develop September 10, 2026 17:29
@Noah-Tervalon-Nvidia

Copy link
Copy Markdown
Collaborator

I'm working on a massive overhaul to the TUI that we will want to bring in before we make other TUI changes. As soon as that comes in I'd love to get this updated and then will verify it against the new codebase.

@sylvesterkaczmarek

Copy link
Copy Markdown
Author

Thanks Noah, and thanks Sherief for moving this onto develop. Makes sense. I’ll rebase and adapt the persistence change once the TUI overhaul lands so it fits the new structure cleanly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: manual nodes are persisted only by the desktop app, so a headless nvpair-tui node loses them on every restart

3 participants