Persist manual nodes in the broker - #60
Open
sylvesterkaczmarek wants to merge 1 commit into
Open
sylvesterkaczmarek wants to merge 1 commit into
sylvesterkaczmarek wants to merge 1 commit into
Conversation
Signed-off-by: Sylvester Kaczmarek <16242628+sylvesterkaczmarek@users.noreply.github.com>
Collaborator
|
This makes sense. Moving MR against develop branch. |
Noah-Tervalon-Nvidia
requested review from
Noah-Tervalon-Nvidia
and removed request for
Noah-Tervalon-Nvidia
September 11, 2026 19:47
Collaborator
|
I'm working on a massive overhaul to the TUI that we will want to bring in before we make other TUI changes. As soon as that comes in I'd love to get this updated and then will verify it against the new codebase. |
Author
|
Thanks Noah, and thanks Sherief for moving this onto develop. Makes sense. I’ll rebase and adapt the persistence change once the TUI overhaul lands so it fits the new structure cleanly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #58
Description
Move manual-node durability into
nvpair-ui-brokerso headless TUI/service nodes keep manual peers across broker and worker restarts. Successful add/remove operations update the existingconfigs/manual-nodes.json, and a restarted manual-nodes worker is repopulated automatically.Scope
nvpair-ui-brokerfrom 0.40.2 to 0.40.3Validation
make check- passed, including 208 desktop unit testsgo test ./...inservices/nvpair-ui-broker- passed-count=3- passednpm run dead-code:check- passedmake test-servicesreaches an existinglmstudio-proxyE2E port-selection failure; the same failing test reproduces on pristinemainRisk
The JSON-RPC surface is unchanged. Existing desktop
manual-nodes.jsonentries remain readable because the broker takes ownership of the same file and schema.Checklist
services/versions.jsonand described the user-visible change above.