Skip to content

Remove CORS allow policy - #63

Open
kjlubick wants to merge 1 commit into
NVIDIA:developfrom
kjlubick:CORS
Open

kjlubick wants to merge 1 commit into
NVIDIA:developfrom
kjlubick:CORS

Conversation

@kjlubick

Copy link
Copy Markdown
Collaborator

Description

PAIR's inference proxy endpoints are intended for native clients, but the shared wildcard CORS policy allowed browser origins to send requests and read proxy or engine responses.

This removes that and updates tests and documentation to match.

This bumps ollama-proxy and lmstudio-proxy because of the new behavior.

Scope

Blocking browser-based queries on our proxies is only layer in a defense-in-depth strategy. See SECURITY.md for more

Validation

I ran tests locally and spun up a local 1-node instance to do inference to make sure one CUJ works.

cd services/shared
go test ./...

cd ../ollama-proxy
go test ./...

cd ../lmstudio-proxy
go test ./...

Risk

There might be other CUJs I'm not familiar with that will break. If they do, we'll want to be more careful than just a wildcard Allow.

Checklist

  • I have read the Contributing Guidelines.
  • Every commit is signed off (git commit -s), certifying the Developer Certificate of Origin.
  • New or existing tests cover the change.
  • Relevant documentation is updated.
  • I checked the diff, changed filenames, and commit messages for credentials, private data, internal URLs, internal issue identifiers, and generated artifacts.
  • I recorded the validation commands and results above.
  • I bumped any affected component in services/versions.json, and described user-visible changes above so they reach the release notes.

PAIR's inference proxy endpoints are intended for native clients, but the shared wildcard CORS policy allowed browser origins to send requests and read proxy or engine responses.

This removes that and updates tests and documentation to match.

Signed-off-by: Kaylee Lubick <klubick@nvidia.com>
@kjlubick
kjlubick requested a review from ckelseynv September 11, 2026 17:19
@kjlubick

Copy link
Copy Markdown
Collaborator Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant