Repository navigation
Conversation
…guide The performance-tuning-guide docs used ../../media/ which resolved to a non-existent docs/source/legacy/media/ directory. The SVG files live at docs/source/media/, so the correct relative path is ../../../media/. Signed-off-by: Ethan Feng <ethan.fengch@gmail.com>
Contributor
📝 WalkthroughWalkthroughUpdated embedded figure paths in two legacy performance tuning guide pages so the referenced images point to the current media directory. ChangesLegacy performance guide image updates
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
@chfeng-cs this pull request has had no activity for more than 120 days. Is it still active? Please post an update when you can. |
Collaborator
|
Thank you for bringing this to our attention. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Seven SVG image links in the legacy performance-tuning-guide docs were broken. The affected files live at:
docs/source/legacy/performance/performance-tuning-guide/, such as https://github.com/NVIDIA/TensorRT-LLM/blob/main/docs/source/legacy/performance/performance-tuning-guide/deciding-model-sharding-strategy.mdEach link used
../../media/<image>.svg, which resolves to:docs/source/legacy/media/. This path does not exist.The actual SVG files are at
docs/source/media/. Because the guide is nested one level deeper than expected, the path was missing one../level.Fix
Changed all 7 occurrences from
../../media/→../../../media/, which correctly resolves todocs/source/media/where the files actually live.Files changed:
deciding-model-sharding-strategy.mdPipeline_Parallel_Vis.svg,Tensor_Parallelism_Vis.svg)tuning-max-batch-size-and-max-num-tokens.mdTRTLLM_Scheduler_Vis_1~4.svg,TRTLLM_Scheduler_Vis_Chunked_Context_1.svg)No content changes — path corrections only.
Summary by CodeRabbit