Skip to content

[None][chore] promote flashinfer-prims-ts source from #20298 - #20731

Merged
yuxianq merged 1 commit into
NVIDIA:release/1.3from
yuxianq:chore/flashinfer-prims-ts-promote-20298-ae3851ab5f95
Oct 21, 2026
Merged

yuxianq merged 1 commit into
NVIDIA:release/1.3from
yuxianq:chore/flashinfer-prims-ts-promote-20298-ae3851ab5f95

Conversation

@yuxianq

@yuxianq yuxianq commented Oct 21, 2026 •

Copy link
Copy Markdown
Collaborator

Dev Engineer Review

The change updates only the flashinfer-prims-ts vendor branch in 3rdparty/vendor_sources.lock.yaml. The source SHA, vendor files, compatibility patch, and digests remain unchanged. No runtime, API, dependency, or source-code changes are reported.

QA Engineer Review

No test changes.

Per-File QA Perspective

  • 3rdparty/vendor_sources.lock.yaml: The vendor source branch changes to trtllm-prims-ts-dev-20261012. QA should verify source materialization and lock integrity; no runtime behavior changes are expected.

Description

Promote the exact source revision reviewed in #20298.
Only the selected vendor lock URL/branch changes. The source SHA, selected vendor files, compatibility patch, and digests are unchanged.

Test Coverage

Source materialization and lock-only diff verified by the promotion tool. No new kernel behavior. The tool posts /bot skip --comment "skip CI since no code change" to request the bot's no-code-change CI path. Automatic GitHub checks and required reviews still apply.

PR Checklist

  • No runtime/API/dependency changes.
  • Immutable source pin and vendor content preserved.
  • Please check this after reviewing the above items as appropriate for this PR.

Required squash commit message

Preserve the following message, including the provenance block and DCO sign-off.

[None][chore] promote flashinfer-prims-ts source from #20298

----- BEGIN VENDOR PROMOTION V1 -----
{
  "attribution": {
    "6b00497398f491136be91fb0e60ac3f314da53ba": {
      "method": "same-edits",
      "upstream_base": "2895577720741ddfedff118202c89584996b8875",
      "upstream_head": "14770b419ec3261c2afc55e401051c92bb7f3fd9"
    },
    "ae3851ab5f958ba22f154059df5b38321f6369d2": {
      "method": "source-series-aggregate",
      "upstream_base": "2895577720741ddfedff118202c89584996b8875",
      "upstream_head": "14770b419ec3261c2afc55e401051c92bb7f3fd9"
    }
  },
  "attribution_scope": {
    "include": [
      "**/*.py"
    ],
    "source": "flashinfer/attention/prims_ts"
  },
  "canonical_branch": "trtllm-prims-ts-dev-20261012",
  "canonical_url": "https://github.com/yuxianq/flashinfer.git",
  "changes": [
    {
      "commits": [
        "6b00497398f491136be91fb0e60ac3f314da53ba",
        "ae3851ab5f958ba22f154059df5b38321f6369d2"
      ],
      "upstream_base": "2895577720741ddfedff118202c89584996b8875",
      "upstream_head": "14770b419ec3261c2afc55e401051c92bb7f3fd9",
      "upstream_merge": "f57c58b898cc0f96ddea03066a3fd66ad201337a",
      "upstream_pr": "https://github.com/flashinfer-ai/flashinfer/pull/6482"
    }
  ],
  "consumer_base": "release/1.3",
  "consumer_merge": "b053431a1a62303d5c3b7a3d9d5af7f82c7c76d0",
  "consumer_pr": "https://github.com/NVIDIA/TensorRT-LLM/pull/20298",
  "contributor_metadata": {
    "metadata_digest": "95942a2db5f1373b658ac1a2010629f282614a3ca905b68fc64f054d39c8129e",
    "pr_author": "yuxianq",
    "source_head": "a7d6732b1e451e67e1d5396251395f6a742a7e4f"
  },
  "kind": "promotion",
  "previous": "ae312f7cc1723b06fda5168105ade0f328ee47d8",
  "promoted": "ae3851ab5f958ba22f154059df5b38321f6369d2",
  "source_branch": "bug-6791733-prims-ts-cuda-graph--source-q-tma-release13",
  "source_url": "https://github.com/yuxianq/flashinfer.git",
  "upstream_base": "ae312f7cc1723b06fda5168105ade0f328ee47d8",
  "upstream_branch": "main",
  "upstream_observed_main": "a3f2525e39dffc98dcad4ce50706641a580358f0",
  "upstream_repository": "flashinfer-ai/flashinfer",
  "vendor": "flashinfer-prims-ts",
  "version": 1
}
----- END VENDOR PROMOTION V1 -----

Signed-off-by: Yuxian Qiu <142763828+yuxianq@users.noreply.github.com>

----- BEGIN VENDOR PROMOTION V1 -----
{
  "attribution": {
    "6b00497398f491136be91fb0e60ac3f314da53ba": {
      "method": "same-edits",
      "upstream_base": "2895577720741ddfedff118202c89584996b8875",
      "upstream_head": "14770b419ec3261c2afc55e401051c92bb7f3fd9"
    },
    "ae3851ab5f958ba22f154059df5b38321f6369d2": {
      "method": "source-series-aggregate",
      "upstream_base": "2895577720741ddfedff118202c89584996b8875",
      "upstream_head": "14770b419ec3261c2afc55e401051c92bb7f3fd9"
    }
  },
  "attribution_scope": {
    "include": [
      "**/*.py"
    ],
    "source": "flashinfer/attention/prims_ts"
  },
  "canonical_branch": "trtllm-prims-ts-dev-20261012",
  "canonical_url": "https://github.com/yuxianq/flashinfer.git",
  "changes": [
    {
      "commits": [
        "6b00497398f491136be91fb0e60ac3f314da53ba",
        "ae3851ab5f958ba22f154059df5b38321f6369d2"
      ],
      "upstream_base": "2895577720741ddfedff118202c89584996b8875",
      "upstream_head": "14770b419ec3261c2afc55e401051c92bb7f3fd9",
      "upstream_merge": "f57c58b898cc0f96ddea03066a3fd66ad201337a",
      "upstream_pr": "flashinfer-ai/flashinfer#6482"
    }
  ],
  "consumer_base": "release/1.3",
  "consumer_merge": "b053431a1a62303d5c3b7a3d9d5af7f82c7c76d0",
  "consumer_pr": "NVIDIA#20298",
  "contributor_metadata": {
    "metadata_digest": "95942a2db5f1373b658ac1a2010629f282614a3ca905b68fc64f054d39c8129e",
    "pr_author": "yuxianq",
    "source_head": "a7d6732b1e451e67e1d5396251395f6a742a7e4f"
  },
  "kind": "promotion",
  "previous": "ae312f7cc1723b06fda5168105ade0f328ee47d8",
  "promoted": "ae3851ab5f958ba22f154059df5b38321f6369d2",
  "source_branch": "bug-6791733-prims-ts-cuda-graph--source-q-tma-release13",
  "source_url": "https://github.com/yuxianq/flashinfer.git",
  "upstream_base": "ae312f7cc1723b06fda5168105ade0f328ee47d8",
  "upstream_branch": "main",
  "upstream_observed_main": "a3f2525e39dffc98dcad4ce50706641a580358f0",
  "upstream_repository": "flashinfer-ai/flashinfer",
  "vendor": "flashinfer-prims-ts",
  "version": 1
}
----- END VENDOR PROMOTION V1 -----

Signed-off-by: Yuxian Qiu <142763828+yuxianq@users.noreply.github.com>
@yuxianq
yuxianq requested review from a team as code owners October 21, 2026 05:48
@yuxianq

yuxianq commented Oct 21, 2026

Copy link
Copy Markdown
Collaborator Author

/bot skip --comment "skip CI since no code change"

@yuxianq
yuxianq enabled auto-merge (squash) October 21, 2026 05:49
@coderabbitai

coderabbitai Bot commented Oct 21, 2026

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: NVIDIA/TensorRT-LLM/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Enterprise
  • Run ID: 636e60d3-2c0b-478c-b559-69aeed76ad16
📥 Commits

Reviewing files that changed from the base of the PR and between b053431 and 6fb4a2c.

📒 Files selected for processing: 1
  • 3rdparty/vendor_sources.lock.yaml

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.

Walkthrough

The vendor source lockfile now points flashinfer-prims-ts to the trtllm-prims-ts-dev-20261012 branch instead of the previous branch.

Changes

Vendor source branch update

Layer / File(s) Summary
Update vendor branch reference
3rdparty/vendor_sources.lock.yaml
The flashinfer-prims-ts branch reference changes to trtllm-prims-ts-dev-20261012.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 6fb4a

No actionable merge-blocking risk is identified.

Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed The title follows the required format and clearly identifies the promotion of the flashinfer-prims-ts source from PR #20298.
Description check Passed The description explains the purpose, scope, test coverage, CI handling, checklist status, and required squash commit metadata. It provides sufficient information for this lock-only promotion.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #79545 [ skip ] triggered by Bot. Commit: 6fb4a2c Link to invocation

@yuxianq

yuxianq commented Oct 21, 2026 •

Copy link
Copy Markdown
Collaborator Author

@farazkh80, could you help to review this PR as trt-llm-torch-attention-devs? Thanks~

Assignment explanation
Componentsintegration/dependencies (100%)
TagsNone identified
PR effort1 points — A single mechanical lockfile edit requires checking that the source pin remains unchanged. The provenance narrative does not increase attention-code review scope.
Affinity (0–1)0.500 component/tag match
Outstanding points at selection30 → 31 (+1)
Points already reserved on this PR0
Effective weight1
Completed review points (preceding 168 hours)63
Combined points after assignment94
Demand-derived target69.00 points (soft share)
Additional fair share before assignment0.00 points
Share explanationWhole PR / qualification or coverage constraint exceeds a soft share; assignment is allowed.
Selection rulebalance-first maintenance
Assignment scope (farazkh80)all

Affinity and workload are snapshots at selection, not live counters. Existing reservations on this PR are counted once.

@yuxianq
yuxianq requested review from farazkh80 and removed request for heyuhhh and lfr-0531 October 21, 2026 06:05
@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #79545 [ skip ] completed with state SUCCESS. Commit: 6fb4a2c
Skipping testing for commit 6fb4a2c

Link to invocation

@yihwang-nv yihwang-nv left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yuxianq
yuxianq merged commit 688e8fd into NVIDIA:release/1.3 Oct 21, 2026
13 of 14 checks passed
@github-actions

Copy link
Copy Markdown

Automatically added "ci: full pre-merge approved" because this PR has satisfied the required GitHub review approvals. Unresolved review conversations and other required checks remain independent merge requirements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants