Skip to content

[None][fix] Backport UCX timer-wheel fix for false UD timeouts #21381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dongfengy wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[None][fix] Backport UCX timer-wheel fix for false UD timeouts #21381

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions docker/common/install_ucx.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,27 @@
#!/bin/bash

# Copyright (c) 2026, NVIDIA CORPORATION. All rights reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

set -ex

# Authenticate the github.com clone below; no-op when no token is available.
source "$(dirname "${BASH_SOURCE[0]}")/github_auth.sh"

UCX_VERSION="v1.23.x"
UCX_COMMIT="65e342a82dd2609a28c8c2b8c45ed7fe2cb33fa0"
UCX_TIMER_FIX_COMMIT="62182080282372e27a5cad45f23b7ac424b7cd94"
UCX_INSTALL_PATH="/usr/local/ucx/"
CUDA_PATH="/usr/local/cuda"
UCX_REPO="https://github.com/openucx/ucx.git"
Expand All @@ -21,6 +37,12 @@ git -C ucx remote add origin ${UCX_REPO}
git -C ucx fetch -q --depth 1 origin ${UCX_COMMIT}
git -C ucx checkout -q FETCH_HEAD

# Advance the timer wheel before callbacks to prevent false UD peer timeouts.
git -C ucx fetch -q --depth 2 origin ${UCX_TIMER_FIX_COMMIT}
git -C ucx diff ${UCX_TIMER_FIX_COMMIT}^ ${UCX_TIMER_FIX_COMMIT} > ucx/ucx-timer-fix.patch
git -C ucx apply ucx-timer-fix.patch
rm ucx/ucx-timer-fix.patch

tar -czf /third-party-source/ucx-${UCX_VERSION}.tar.gz ucx
cd ucx
# Pull external/gpunetio shallow, for the same reason: autogen.sh below does a
Expand Down
Loading