Skip to content

Document Dragon GPU sharing, MPS and MPI execution - #100

Merged
tpn merged 2 commits into
mainfrom
codex/dragon-architecture-docs
Oct 9, 2026
Merged

tpn merged 2 commits into
mainfrom
codex/dragon-architecture-docs

Conversation

@tpn

@tpn tpn commented Oct 6, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Explain how cuPhoton assigns work to GPUs, uses Dragon queues and MPI collectives, and validates completion. Cover optional GPU sharing, MPS connection checks and external service ownership. Add five diagrams and links to the implementation, and preserve the existing Dragon transport measurements in a separate page.

Why this is needed

The launch guide shows how to run a job. These pages explain what its processes do, which GPU each worker uses, and where the data goes. They distinguish multiple workers sharing a GPU from the default placement, and the shared worker lifecycle from the separate xPois paths.

Validation

  • Compared the descriptions with the executors and component adapters; rendered and visually checked all five Mermaid diagrams.
  • Checked 92 relative links and heading anchors.
  • make ci-lint, make test-cpu and make build passed during the original documentation validation: 2,862 CPU tests passed, 210 skipped for GPU/optional-runtime support. The run emitted 40 Astropy FITS keyword warnings.
  • Documentation-only change relative to main. No new MPS performance or multi-node qualification.

Repository hygiene

  • No credentials, private paths, local datasets, notebook outputs, or generated run artifacts were added.
  • Large binary artifacts are excluded or intentionally tracked through an approved storage plan.
  • Security-sensitive information is not included.
  • User-visible behavior changes are documented.
  • New dependencies and their licenses are documented (none added here).

@tpn
tpn requested a review from melo-gonzo as a code owner October 6, 2026 00:51
@coderabbitai

coderabbitai Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (1)
  • ai-review

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: NVIDIA/cuPhoton/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Enterprise
  • Run ID: 97a69ef2-0827-4f33-bd4f-3977b37139d7

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@tpn
tpn force-pushed the codex/dragon-architecture-docs branch from d8468d6 to 52e79cf Compare October 6, 2026 01:16
@tpn tpn changed the title Document Dragon and MPI execution architecture Document Dragon GPU sharing, MPS and MPI execution Oct 6, 2026
@tpn
tpn changed the base branch from main to codex/gpu-sharing-20260929 October 6, 2026 01:16
Comment thread docs/mpi.md Outdated

@melo-gonzo melo-gonzo left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with one nonblocking correction inline about MPI import ordering. The remaining reviewed architecture descriptions and local links match the implementation.

@tpn
tpn force-pushed the codex/gpu-sharing-20260929 branch from 4c8cdd7 to 04a2e61 Compare October 9, 2026 20:26
tpn added 2 commits October 9, 2026 13:34
Explain worker placement, data movement and completion protocols.
Separate the architecture overview from Dragon transport measurements.

Signed-off-by: Trent Nelson <trentn@nvidia.com>
Signed-off-by: Trent Nelson <trentn@nvidia.com>
@tpn
tpn changed the base branch from codex/gpu-sharing-20260929 to main October 9, 2026 20:35
@tpn
tpn force-pushed the codex/dragon-architecture-docs branch from 52e79cf to ad317a3 Compare October 9, 2026 20:35
@tpn
tpn merged commit 01dd4e3 into main Oct 9, 2026
61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants