Repository navigation
Document Dragon GPU sharing, MPS and MPI execution - #100
Merged
Merged
Conversation
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one) (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
tpn
force-pushed
the
codex/dragon-architecture-docs
branch
from
October 6, 2026 01:16
d8468d6 to
52e79cf
Compare
melo-gonzo
reviewed
Oct 9, 2026
melo-gonzo
approved these changes
Oct 9, 2026
melo-gonzo
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, with one nonblocking correction inline about MPI import ordering. The remaining reviewed architecture descriptions and local links match the implementation.
tpn
force-pushed
the
codex/gpu-sharing-20260929
branch
from
October 9, 2026 20:26
4c8cdd7 to
04a2e61
Compare
Explain worker placement, data movement and completion protocols. Separate the architecture overview from Dragon transport measurements. Signed-off-by: Trent Nelson <trentn@nvidia.com>
Signed-off-by: Trent Nelson <trentn@nvidia.com>
tpn
force-pushed
the
codex/dragon-architecture-docs
branch
from
October 9, 2026 20:35
52e79cf to
ad317a3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Explain how cuPhoton assigns work to GPUs, uses Dragon queues and MPI collectives, and validates completion. Cover optional GPU sharing, MPS connection checks and external service ownership. Add five diagrams and links to the implementation, and preserve the existing Dragon transport measurements in a separate page.
Why this is needed
The launch guide shows how to run a job. These pages explain what its processes do, which GPU each worker uses, and where the data goes. They distinguish multiple workers sharing a GPU from the default placement, and the shared worker lifecycle from the separate xPois paths.
Validation
make ci-lint,make test-cpuandmake buildpassed during the original documentation validation: 2,862 CPU tests passed, 210 skipped for GPU/optional-runtime support. The run emitted 40 Astropy FITS keyword warnings.Repository hygiene