Skip to content

Reduce duplicate CI package image downloads - #103

Merged
tpn merged 1 commit into
mainfrom
codex/ci-package-pulls-20261015
Oct 16, 2026
Merged

tpn merged 1 commit into
mainfrom
codex/ci-package-pulls-20261015

Conversation

@tpn

@tpn tpn commented Oct 15, 2026

Copy link
Copy Markdown
Collaborator

Summary

Registry throttling has been failing installed-wheel/runtime checks before tests start. A PR revision currently pulls the same Python images in 12 separate jobs on both the PR event and its vetted push.

Run native wheel qualification once on the vetted push, alongside GPU checks. Ordinary PRs retain lint, CPU, and conda checks; ci-required still requires the complete native wheel matrix and GPU checks to succeed. Release builds retain full qualification.

Combine installed-wheel and runtime checks into six Python/architecture jobs. Each job pulls its existing pinned image once and runs the checks in separate fresh containers, reducing normal Python-image downloads from 24 to six per PR revision. Pulls have three bounded attempts; installation and test failures remain final. Python 3.12–3.14, both architectures, and existing Dragon coverage are preserved.

Using an authenticated shared cache remains a follow-up requiring CPU runner access. This change reduces traffic and handles transient pull failures; persistent registry quotas can still block CI.

Validation

  • make ci-lint: passed.
  • uv run --locked --extra dev pytest -q tests/test_release.py: 47 passed.
  • Actionlint and extracted-shell ShellCheck: passed, excluding actionlint's unsupported existing concurrency.queue key.
  • Executed the aggregate shell across 134 status cases; verified successful pulls, recovery, exhausted retries, and unretried test failures with stubbed commands.
  • GitHub-hosted execution of the revised workflow remains pending.

Repository hygiene

  • No credentials, private paths, local datasets, notebook outputs, or generated run artifacts were added.
  • No large binary artifacts were added.
  • Security-sensitive information is not included.
  • Contributor CI behavior is documented.
  • No new dependencies were added.

Run native wheel qualification on vetted pushes alongside GPU checks.
Share one pinned image between separate installation and runtime
containers, with bounded retries for image pulls only.

Signed-off-by: Trent Nelson <trentn@nvidia.com>
@tpn
tpn requested a review from melo-gonzo as a code owner October 15, 2026 21:53
@coderabbitai

coderabbitai Bot commented Oct 15, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one): 1
  • ai-review

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: NVIDIA/cuPhoton/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Enterprise
  • Run ID: 17b2d23a-cd45-46fd-b31c-562ca7334d61

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@melo-gonzo melo-gonzo left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This reduces duplicate image pulls while preserving package coverage and the required CI checks. Local release tests and CI status/retry checks passed. The two remaining CI failures are registry quota errors before tests start; a successful rerun is still needed.

@tpn
tpn merged commit ffb1d38 into main Oct 16, 2026
105 of 112 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants