Repository navigation
Conversation
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one): 1
Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
tpn
force-pushed
the
codex/numba-xfit-main-20260930
branch
from
October 5, 2026 02:48
08a39e6 to
cd776e0
Compare
tpn
force-pushed
the
codex/numba-xfit-host-20260930
branch
from
October 5, 2026 02:48
d544aaf to
20b65af
Compare
tpn
force-pushed
the
codex/numba-xfit-main-20260930
branch
from
October 9, 2026 20:46
cd776e0 to
bed540e
Compare
tpn
force-pushed
the
codex/numba-xfit-host-20260930
branch
from
October 9, 2026 20:46
20b65af to
009ed32
Compare
tpn
force-pushed
the
codex/numba-xfit-main-20260930
branch
from
October 9, 2026 21:09
bed540e to
0bd3868
Compare
tpn
force-pushed
the
codex/numba-xfit-host-20260930
branch
2 times, most recently
from
October 15, 2026 18:05
4ccd920 to
63b7967
Compare
tpn
force-pushed
the
codex/numba-xfit-main-20260930
branch
from
October 15, 2026 18:05
0bd3868 to
9aa4b56
Compare
Filter normal-equation rows only when a fallback was needed. Skip the second residual-budget filter for analytic derivatives; keep it for finite differences, with a boundary regression test. Signed-off-by: Trent Nelson <trentn@nvidia.com>
tpn
force-pushed
the
codex/numba-xfit-main-20260930
branch
from
October 16, 2026 18:47
9aa4b56 to
d940e53
Compare
tpn
force-pushed
the
codex/numba-xfit-host-20260930
branch
from
October 16, 2026 18:47
63b7967 to
2b2222c
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The normal-equation path copied five arrays even when every row was valid,
and filtered trial-evaluation budgets after analytic Jacobians that consume no
residual evaluations. Skip those operations to reduce repeated host work in
xFit's shared solver. Preserve fallback filtering and finite-difference budget
checks, with a regression for exhausting the budget just before a trial in both
implicit and explicitly requested finite-difference modes. Builds on #85.
Validation on the integrated source (Python 3.12, CUDA 13):
Earlier free-threaded Python 3.14 testing with Numba-CUDA-MLIR 0.5.4 exposed
an intermittent concurrent-startup failure in dependency type dispatch.
These Python 3.12 runs do not qualify free-threaded concurrent-startup reliability.