Repository navigation
Conversation
Use Cargo target names for standalone emit-ltoir artifacts. Bind the compiler and reader to the same intermediate directory when invoked from a Cargo workspace member. Signed-off-by: Trent Nelson <trent@trent.me>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cargo oxide emit-ltoircould compile successfully and then read the wrong.llfile when a directory differed from its Cargo target name or the command ran from a workspace member. Resolve the standalone target from Cargo metadata and use the same intermediate directory for compilation and reading.Changes
CUDA_OXIDE_PTX_DIRfor both writer and reader, including workspace-relative overrides. Refresh that target's generated files there before reading fresh IR.Testing
just checkwas not run.Checklist