Repository navigation
Conversation
Accept ordered external LTO files when materializing embedded cubins. Include their content in the codegen fingerprint and verify owned bytes before linking through the existing finalizer. Preserve inputs that overlap generated output paths and diagnose unresolved device symbols. Add a standalone CUDA FFI example and a native regression script. Signed-off-by: Trent Nelson <trent@trent.me>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
2 tasks done
Reuse existing example dependency pins and classify external LTO as an FFI fixture. Run its linking regression in native sweeps and verify relocatable debug output in the existing full-debug route. Signed-off-by: Trent Nelson <trent@trent.me>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
External CUDA device functions currently prevent
--materialize-cubinfrom producing a self-contained executable. Add repeatable--link-ltoirinputs so Rust kernels can call CUDA C++ helpers through the existing nvJitLink finalizer and load the resulting embedded cubin normally.Changes
Testing
On CUDA 13.3 / sm_120: 320 focused host tests, 20 doctests, formatting and clippy passed. The native regression passed all ten stages, including content-only rebuilds, missing/corrupt inputs, collision preservation, and execution after removing inputs. Memcheck reported zero errors. Existing materialized
vecaddalso passed. Six pre-existing finalizer tests remain ignored; the fulljust checksuite was not run.Checklist
This PR remains draft.