Repository navigation
Conversation
Carry the convergence marker through private dependency metadata and emit it on each marked LLVM declaration before native optimization. Deduplicate repeated extern symbols while rejecting incompatible signatures and convergence requirements. Signed-off-by: Trent Nelson <trent@trent.me>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
This was referenced Oct 20, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#[convergent]previously disappeared during macro expansion, and device extern declarations reached native optimization without the attribute. Preserve the marker across private dependency metadata and emit convergence on each marked declaration, including externs reached through a downstream generic helper.Also deduplicate extern declarations during lowering. Reachable declarations of the same symbol must agree on their signature and convergence requirements; conflicting declarations produce an error.
Validated with 1,629 host/backend tests, native libNVVM checks in both LLVM dialects, cross-crate and LLVM optimization probes, and five existing GPU checks. The duplicate-declaration regression fails without the fix. This preserves optimization constraints; callers still own collective participation and synchronization.