Skip to content

chore(ci): code coverage reporter - #319

Merged
coryrylan merged 1 commit into
mainfrom
topic-test-coverage-reporter
Sep 18, 2026
Merged

coryrylan merged 1 commit into
mainfrom
topic-test-coverage-reporter

Conversation

@coryrylan

@coryrylan coryrylan commented Sep 18, 2026

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • New Features

    • Added automated code coverage reporting for supported pushes and same-repository pull requests.
    • Coverage results are now published in a format compatible with GitHub Code Quality checks.
    • Added automatic labels for changes to plot and scene projects.
  • Documentation

    • Updated coverage guidance, including setup requirements and recommended coverage thresholds.
  • Chores

    • Improved coverage generation, validation, and tracking across project packages.
    • Coverage output is now consistently recognized by automated build tasks.

@coryrylan coryrylan self-assigned this Sep 18, 2026
@github-actions github-actions Bot added scope(ci) scope(internals) scope(code) scope(forms) scope(markdown) scope(monaco) dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code labels Sep 18, 2026
@coderabbitai

coderabbitai Bot commented Sep 18, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: NVIDIA/elements/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Enterprise

Run ID: f0eb3be8-33e2-453f-ba9a-2c9f8310193c

📥 Commits

Reviewing files that changed from the base of the PR and between b983eea and 9b14a2c.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (1)
  • projects/internals/ci/package.json

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.


📝 Walkthrough

Walkthrough

The change configures merged Vitest coverage reporting, generates Cobertura XML, uploads coverage for eligible CI runs, tracks coverage outputs, and adds plot and scene label rules.

Changes

Coverage reporting pipeline

Layer / File(s) Summary
Coverage inputs and generated outputs
package.json, pnpm-workspace.yaml, projects/internals/vite/..., projects/{code,forms,markdown,monaco}/package.json
Coverage dependencies, JSON reporters, test isolation, and generated coverage outputs are configured.
Coverage report generation
projects/internals/ci/coverage-projects.js, projects/internals/ci/coverage.js, projects/internals/ci/ci-summary.js
Project coverage files are loaded, validated, merged, and written as coverage/cobertura.xml.
CI orchestration and upload
projects/internals/ci/package.json, .github/workflows/ci.yml, projects/internals/ci/README.md
CI runs coverage, uploads the Cobertura report for eligible events, and documents the reporting configuration.

Project label rules

Layer / File(s) Summary
Plot and scene label rules
.github/labeler.yml
Changes under projects/plot/** and projects/scene/** receive matching scope labels.

Priority: ➖ Normal

Estimated code review effort: 3 (Moderate) | ~25 minutes

Change: Feature

Suggested reviewers: cursoragent

Sequence Diagram(s)

sequenceDiagram
  participant ProjectTests as project test:coverage tasks
  participant CoverageGenerator as generateCoverageReport
  participant CIWorkflow as GitHub Actions CI
  participant CodeQuality as GitHub Code Quality
  ProjectTests->>CoverageGenerator: provide coverage-final.json files
  CoverageGenerator->>CIWorkflow: write coverage/cobertura.xml
  CIWorkflow->>CodeQuality: upload TypeScript coverage
Loading

Merge Risk: ⚪ Minimal · up to 9b14a

The coverage pipeline and CI upload wiring have no confirmed failure, so this change is mergeable with normal checks.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 5 functions across 5 files. (1 skipped: 1 … Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately and concisely describes the main change: adding a CI code coverage reporter and reporting workflow.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 5 functions across 5 files. (1 skipped: 1 unsupported.)

  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@coryrylan
coryrylan force-pushed the topic-test-coverage-reporter branch from 5073fd3 to e43e75e Compare September 18, 2026 18:38
@github-code-quality

github-code-quality Bot commented Sep 18, 2026

Copy link
Copy Markdown

Code Coverage Overview

Languages: TypeScript

TypeScript / code-coverage/vitest

The overall line coverage in commit 9b14a2c in the topic-test-coverage-... branch is 99%. Line coverage data for the main branch is not yet available.

Show a line coverage summary of the most covered files.
File main topic-test-coverage-... 9b14a2c +/-
projects/core/s...box/combobox.ts 100%
projects/monaco...l/base/input.ts 100%
projects/monaco...ems/problems.ts 100%
projects/core/s...e.controller.ts 100%
projects/forms/...ixins/button.ts 99%
projects/intern...api/validate.ts 99%
projects/forms/...xins/control.ts 98%
projects/core/s...r.controller.ts 97%
projects/core/s...al/utils/dom.ts 95%
projects/cli/src/install.ts 88%

Updated September 18, 2026 20:40 UTC

@coryrylan
coryrylan force-pushed the topic-test-coverage-reporter branch from e43e75e to b983eea Compare September 18, 2026 20:08
Comment thread projects/internals/ci/package.json Outdated
"ci-profile.test.js",
"coverage-projects.js",
"coverage.js",
"coverage.test.js",

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Proactively adding this reference to coverage.test.js for a follow-up, or is the file missing?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, it was dead code

Signed-off-by: Cory Rylan <crylan@nvidia.com>
@coryrylan
coryrylan force-pushed the topic-test-coverage-reporter branch from b983eea to 9b14a2c Compare September 18, 2026 20:34
@coryrylan
coryrylan enabled auto-merge (rebase) September 18, 2026 20:35
@coryrylan
coryrylan merged commit ae0e423 into main Sep 18, 2026
15 checks passed
@coryrylan
coryrylan deleted the topic-test-coverage-reporter branch September 18, 2026 20:49
@coryrylan

Copy link
Copy Markdown
Collaborator Author

🎉 This issue has been resolved in version 2.8.0 🎉

Changelog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants