Conversation
Support multinode when testing with json format output (`-j`), which fixed these issues: - Missing device info of remote nodes in json output - Unexpected local node d2d bandwidth value due to variable `localDevice` not being updated through MPI - MPI_ABORT invoked in multinode broadcast testcases and also in test with option `-j -p multinode` Signed-off-by: Shady Chan <chenyulin.shady@bytedance.com>
Author
|
@ramasubramanianrahul @deepakcu @esitaridi |
jingxu9x
added a commit
to jingxu9x/nvbandwidth
that referenced
this pull request
Sep 11, 2026
Support multinode when testing with json format output (`-j`), which fixes these issues: - Missing device info of remote nodes in json output - Unexpected local node d2d bandwidth value due to variable `localDevice` not being updated through MPI - MPI_ABORT invoked in multinode broadcast testcases and also in test with option `-j -p multinode` Rebased NVIDIA#54 onto current main, resolving conflicts with the unified multinode/single-node path and the `--pair`/UUID and per-node warning logic added since v0.8. `recordDevices`' caller now passes `deviceCount` instead of `worldSize`, so the JSON and perf-parser outputs iterate the device count rather than the world size (the source of CUDA_ERROR_INVALID_DEVICE on multinode `--json` runs). Co-authored-by: Shady Chan <chenyulin.shady@bytedance.com> Signed-off-by: Shady Chan <chenyulin.shady@bytedance.com> Signed-off-by: jingxuz <jingxuz@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support multinode when testing with json format output (
-j), which fixed these issues:localDevicenot being updated through MPI-j -p multinode