feat(vanity-gateway): pass the LLM Gateway endpoint through the stack - #1026
Open
Max-NV wants to merge 1 commit into
Open
feat(vanity-gateway): pass the LLM Gateway endpoint through the stack#1026Max-NV wants to merge 1 commit into
Max-NV wants to merge 1 commit into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Max-NV
marked this pull request as draft
August 20, 2026 00:58
Max-NV
force-pushed
the
mxing/vanity-gateway-llm-endpoint-chart
branch
from
August 26, 2026 20:10
a404d9a to
98cbd52
Compare
Max-NV
force-pushed
the
mxing/vanity-gateway-llm-stack-wiring
branch
2 times, most recently
from
August 26, 2026 22:14
55ca6f7 to
6a65d40
Compare
The self-managed stack enumerates the Vanity Gateway config keys one by one when rendering chart values, so llmGatewayEndpoint was dropped and the gateway failed to start with "LLM_GATEWAY_ENDPOINT is required when a model sets functionType LLM". The mappingConfig half already passed through untouched, so an LLM-routed model could be configured but never worked. Adds the key to the rendered config block and documents it in base.yaml with the in-cluster LLM Gateway as the default. Chart and image pins are not bumped here. Both need a published artifact carrying the service-side change, which does not exist yet. Signed-off-by: Max Xing <mxing@nvidia.com>
Max-NV
force-pushed
the
mxing/vanity-gateway-llm-stack-wiring
branch
from
August 26, 2026 22:56
6a65d40 to
4ff3cc1
Compare
This was referenced Aug 26, 2026
Max-NV
marked this pull request as ready for review
August 27, 2026 03:49
FamousDirector
approved these changes
Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The self-managed stack does not pass the Vanity Gateway's
configblock through wholesale. It enumerates the keys one at a time when rendering chart values, sollmGatewayEndpointwas dropped even after #1025 added it to the chart.The
mappingConfighalf of the values does pass through untouched. The result is that an operator can mark anopenaimodel withfunctionType: LLMand have the mapping land correctly, while the endpoint the gateway needs to act on it never arrives, so the container fails at startup withLLM_GATEWAY_ENDPOINT is required when a model sets functionType LLM.What changed
Adds
llmGatewayEndpointto the renderedvanityGateway.configblock inglobal.yaml.gotmpl, defaulted to the in-cluster LLM Gateway service, and documents it inbase.yamlnext to the other Vanity Gateway config keys.Customer Release Notes
Self-managed installs can now configure the Vanity Gateway's LLM Gateway endpoint.
Plan Summary
One additional key in the values rendered for the
vanity-gatewayrelease. No resource changes for installs that do not use LLM-routed models.Usage
Models that set
functionType: LLMalso needaddons.llm.enabled, which deploys the LLM Gateway.Testing
Rendered the self-managed stack and confirmed the key reaches the chart values.
Not covered by the end-to-end run recorded on #1022. That cluster ran the chart installed
directly from the working tree rather than through the stack, so this rendering path was not
exercised live. The value it needs to produce is the same one that run used.
No QA needed.
Notes
Chart and image pins are not bumped here. Both need a published artifact carrying the #1022 service change, which does not exist yet.
Stacked on #1025, which adds the chart key. Merging this first would break installs: the chart config block is
additionalProperties: false, so it would reject the value the stack now sends. Base is set to that branch and will retarget tomainwhen it merges.References
None
Related Pull Requests
Dependencies
None
Issues
Relates to #1021