fix(admin-token-issuer-proxy): separate readiness from liveness - #1237
Draft
mikeyrcamp wants to merge 1 commit into
Draft
fix(admin-token-issuer-proxy): separate readiness from liveness#1237mikeyrcamp wants to merge 1 commit into
mikeyrcamp wants to merge 1 commit into
Conversation
Signed-off-by: Mike Camp <mcamp@nvidia.com>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueComment |
This was referenced Aug 26, 2026
FamousDirector
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
/readyzendpoint for Kubernetes readiness/healthzas the process liveness endpointWhy
The admin token issuer proxy can start before API Keys has completed a cold
start. A compatible application image keeps the process live while retrying
transient metadata failures, but it must not receive traffic until that
metadata is initialized.
Related to #1229.
Validation
helm templateassertion confirms readiness renders/readyzhelm lint deploy/helm/admin-token-issuer-proxy/chart ...tools/ci/check-helm-charts(14 charts linted and rendered)Dependency
This PR must remain draft until a compatible application image containing the
/readyzendpoint is released and the default image tag is updated. Theapplication change is prepared, but its owning source repository is currently
archived.
No third-party dependencies are added.