fix(nvca): backport intra-namespace NetworkPolicy isolation fix to 3.2 (#1256) - #1301
Merged
rohithb-hub merged 1 commit intoAug 28, 2026
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Contributor
apartha-nv
approved these changes
Aug 28, 2026
rohithb-hub
merged commit Aug 28, 2026
a7c1f00
into
release-src/compute-plane-services/nvca/v3.2
14 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…2 (#1256)
(cherry picked from commit 1ad8682)
TL;DR
Backports #1256 to the
3.2release branch: removes the two NVCA-owned NetworkPolicy rules that combined to let any pod in the sharednvcf-backendnamespace reach any other pod in that namespace, on any port, plus the follow-up best-effort startup cleanup of any already-created copy of the leftover egress policy. Per-instance function/MiniService namespaces are unaffected — both rules stay there since they're needed for legitimate same-namespace pod-to-pod communication.Additional Details (optional for docs, build, test, refactor, ci, chore, style, and revert PRs)
Clean cherry-pick of
1ad86826(the squashedmaincommit for #1256) ontorelease-src/compute-plane-services/nvca/v3.2:(cherry picked from commit 1ad8682)
No conflicts, no 3.2-specific adjustments needed —
go buildandgo testpass unmodified on this branch.For the Reviewer
internal/util/k8sutil/netpol.goandpkg/nvca/backendk8scache.goare the core of the change.For QA (optional for docs, build, test, refactor, ci, chore, style, and revert PRs)
go build ./...— clean.go test ./internal/util/k8sutil/... ./pkg/nvca/...— all green.Issues
NO-REF
Checklist