Skip to content

fix(cli): honor task secret opt-in #461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
goingforstudying-ctrl wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(cli): honor task secret opt-in #461

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
10ef3e2
fix(cli): honor task secret opt-in
goingforstudying-ctrl Jul 26, 2026
65e77b0
Merge branch 'main' into goingforstudying-ctrl/fix/task-secret-opt-in
sbaum1994 Aug 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions src/clis/nvcf-cli/internal/client/tasks.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -360,16 +360,17 @@ func (c *Client) ListBasicTaskDetails(ctx context.Context, taskIDs []string) (*L
return decodeNVCT[ListBasicTaskDetailsResponse](resp)
}

// GetTask returns full details for a single task. When includeSecrets is true,
// secret values are included in the response (subject to API authorization).
// GetTask returns full details for a single task. includeSecrets controls
// whether secret names are included in the response.
func (c *Client) GetTask(ctx context.Context, taskID string, includeSecrets bool) (*TaskResponse, error) {
if taskID == "" {
return nil, fmt.Errorf("taskId is required")
}
endpoint := fmt.Sprintf("/v1/nvct/tasks/%s", url.PathEscape(taskID))
if includeSecrets {
endpoint += "?includeSecrets=true"
}
endpoint := fmt.Sprintf(
"/v1/nvct/tasks/%s?includeSecrets=%t",
url.PathEscape(taskID),
includeSecrets,
)

resp, err := c.makeNVCTRequest(ctx, "GET", endpoint, nil)
if err != nil {
Expand Down
2 changes: 1 addition & 1 deletion src/clis/nvcf-cli/internal/client/tasks_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,7 +297,7 @@ func TestGetTaskWithSecrets(t *testing.T) {
wantPath string
wantQS string
}{
{"without flag", false, "/v1/nvct/tasks/task-id", ""},
{"without flag", false, "/v1/nvct/tasks/task-id", "includeSecrets=false"},
{"with flag", true, "/v1/nvct/tasks/task-id", "includeSecrets=true"},
}
for _, tt := range tests {
Expand Down
Loading