Repository navigation
feat(app-shell): fold pages into a menu on narrow screens; account menu - #85
Merged
Merged
Conversation
- Below md the top-right pages fold into one 頁面選單 button of the same links - account can be a link or a menu under the member's name (e.g. 登出) - export cornerLinkClassName for custom corner items that are not links - DESIGN.md: replace the no-menu-button rule Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From migrating llm.winlab.tw (NYCU-WinLab/llm.winlab.tw#80): five pages plus the account do not fit beside the breadcrumb on a phone, and a signed-in member needs somewhere to sign out.
mdthe top-right pages fold into one 頁面選單 button; the menu holds the same links (role link), the breadcrumb and account stayaccountis a link as before, or{label, tip, menu}opening a dropdown ofDropdownMenuItemscornerLinkClassNamefor corner items that are not links (apps were copying the class string)Checked on sandbox: lint, typecheck, format, tokens, build. A temporary page with 5 pages and an account menu: desktop shows the links and no menu button; at 390px the links hide, 頁面選單 opens them, and 登出 fires from the account menu in both.
🤖 Generated with Claude Code