Add detail for developer accessibility testing expectations - #131
Merged
Conversation
7emansell
requested review from
EdwinGuzman,
chrismulholland,
oliviawongnyc and
samanthaandrews
August 25, 2026 14:00
oliviawongnyc
approved these changes
Aug 25, 2026
oliviawongnyc
left a comment
oliviawongnyc
left a comment
There was a problem hiding this comment.
A couple nitpicks. Otherwise, looks great! Thanks again for spearheading this.
|
|
||
| Developers SHOULD have repo tools or IDE tools installed to help fix accessibility issues as they code. For example, the [eslint-plugin-jsx-a11y](https://github.com/evcohen/eslint-plugin-jsx-a11y) is an ESLint plugin that can be added to check for errors when running the app's code through ESLint. Some IDEs and text editors (Atom, for example), can pick up the configuration and tell you the errors as you code. | ||
|
|
||
| Developers SHOULD test their code with common screenreaders and magnification software. |
There was a problem hiding this comment.
Maybe link to the manual testing file? Like, "More information on how you can do this may be found in...."
|
|
||
| _\*Note: Visual QA and Accessibility Testing are currently owned by the accessibility consultant and the design team, and the process for these types of testing remains unchanged at this time._ | ||
| \* Visual QA is owned by the design team. | ||
| \*\* Accessibility testing is owned by the accessibility consultant, but should be supplemented by manual testing. See [Developer Accessibility Testing](#developer-accessibility-testing). |
There was a problem hiding this comment.
I know this doc is all about manual testing, but I would clarify again here because there are other types of accessibility testing that devs own.
"Manual accessibility testing is owned by the accessibility consultant, but should be supplemented by developers. See Developer Accessibility Testing."
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.