SCHOL-905: Implement mobile designs - #209
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
nprotheroNYPL
left a comment
There was a problem hiding this comment.
Looks good, also fixes zIndex issue where toolbar is seen above mobile chat drawer.
On thing that I noticed is that on mobile and tablet sizes, while the toolbar is sticky, it gets covered by the PDF's content. Not sure what the desired interaction is, however this differs from desktop behavior.
Collaborator
Author
Updated the toolbar to not be sticky on mobile/tablet sizes to maximize space. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SCHOL-905
HeadertoToolbarViewControls,PageNavigation, andDocActionsToolbaruses container queries with a responsive grid layout that stacks nav/view/actions on mobile/tablet screens and switches to a single row (view | nav | actions) for desktop container widthsScreenshot

Testing
Vercel /pdf/fixed-height-embedded-collection
After testing, restore with:
git checkout package.json package-lock.json && npm install.