Skip to content

SCHOL-905: Implement mobile designs - #209

Merged
jackiequach merged 4 commits into
mainfrom
SCHOL-905/mobile-designs
Aug 27, 2026
Merged

SCHOL-905: Implement mobile designs#209
jackiequach merged 4 commits into
mainfrom
SCHOL-905/mobile-designs

Conversation

@jackiequach

@jackiequach jackiequach commented Aug 25, 2026

Copy link
Copy Markdown
Collaborator

SCHOL-905

  • Renames Header to Toolbar
  • Splits the component into ViewControls, PageNavigation, and DocActions
  • Toolbar uses container queries with a responsive grid layout that stacks nav/view/actions on mobile/tablet screens and switches to a single row (view | nav | actions) for desktop container widths
  • Updates breakpoints to match DS breakpoints values

Screenshot
image

Testing

Vercel /pdf/fixed-height-embedded-collection

  1. Build & pack this branch
cd web-reader
npm run build
rm -f nypl-web-reader-*.tgz  # clean up old builds if exists
npm pack                     # → nypl-web-reader-5.0.2.tgz
  1. Install the tarball into the enhanced-search web app
cd ../enhanced-search/web
npm install ../../web-reader/nypl-web-reader-5.0.2.tgz
rm -rf .next
npm run dev

After testing, restore with: git checkout package.json package-lock.json && npm install.

@vercel

vercel Bot commented Aug 25, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
web-reader Ready Ready Preview Aug 26, 2026 8:31pm

Request Review

@jackiequach
jackiequach marked this pull request as ready for review August 26, 2026 14:45
@jackiequach
jackiequach requested a review from alea12 as a code owner August 26, 2026 14:45

@nprotheroNYPL nprotheroNYPL left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, also fixes zIndex issue where toolbar is seen above mobile chat drawer.

On thing that I noticed is that on mobile and tablet sizes, while the toolbar is sticky, it gets covered by the PDF's content. Not sure what the desired interaction is, however this differs from desktop behavior.

@jackiequach

Copy link
Copy Markdown
Collaborator Author

On thing that I noticed is that on mobile and tablet sizes, while the toolbar is sticky, it gets covered by the PDF's content. Not sure what the desired interaction is, however this differs from desktop behavior.

Updated the toolbar to not be sticky on mobile/tablet sizes to maximize space.

@nprotheroNYPL nprotheroNYPL left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@jackiequach
jackiequach merged commit 2224cca into main Aug 27, 2026
7 checks passed
@jackiequach
jackiequach deleted the SCHOL-905/mobile-designs branch August 27, 2026 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants