Repository navigation
D217 — a platform test never waits on the machine's end-to-end lock - #393
Merged
Merged
Conversation
test_evidence.py starts real end-to-end runs, which take the machine's lock ($XDG_RUNTIME_DIR/nstack-e2e.lock). While another project ran its own end-to-end tests, the platform suite hung there. Every test now has a runtime folder of its own. Agent-Session: nstack-os-d217 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
napkinstack-agent
Bot
force-pushed
the
tests-own-e2e-lock
branch
from
November 14, 2026 15:02
b4576ff to
2df197e
Compare
napkinstack-admin
approved these changes
Nov 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The platform suite hung, intermittently, at the same test:
test_evidence.pystarts real end-to-end runs, which take the machine's end-to-end lock ($XDG_RUNTIME_DIR/nstack-e2e.lock, one run at a time). When another project on the workstation was running its own end-to-end tests, rightly holding that lock, the suite waited for it, for many minutes.What
platform/tests/conftest.py: an autouse fixture gives every test its ownXDG_RUNTIME_DIR(mode 700). No test takes or waits on the machine's lock; the lock's own tests already set theirs.Checks
test_evidence.pyhung untiltimeout. With this change, under the same held lock, it passes: 78 tests in 5 s.uv run bash platform/tests/run.sh: OK (below).Register row D217. Test infrastructure only; nothing a project receives changes.
🤖 Generated with Claude Code