Skip to content

D218 — the pull request check runs on the pull request's own events only - #395

Merged
napkinstack-agent[bot] merged 1 commit into
mainfrom
head-events-only
Nov 14, 2026
Merged

napkinstack-agent[bot] merged 1 commit into
mainfrom
head-events-only

Conversation

@napkinstack-agent

@napkinstack-agent napkinstack-agent Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

Closes #394.

Why

On an attested project, a code owner usually approves before the record is complete. The review triggered the required « Test sheet and cycle », and that run failed (A2). The record then completes by a notes push, which is no event. A later pull_request run of the same head passed, yet the ruleset kept refusing the merge on the review's failed run, kept beside it: HTTP 405, BLOCKED. An agent's App cannot re-run a workflow, so only the person could unblock it.

What

  • skeleton/.github/workflows/pull-request.yml: the job runs on pull_request events only, with no pull_request_review trigger.
  • A review or a comment stays a verifier's hand (T2), read at the next run, which any edit of the description starts, an agent's included. T2's message, the traces() docstring and verification.md say so.
  • Not chosen:
    • an if: that skips the job on a review: it leaves a required check « skipped », which GitHub counts as passed;
    • a separate review job: this one reads no approval;
    • cancel-in-progress: it never touches a completed run.

Migration (for v0.29.0's notes)

nstack update merges the workflow. A pull request already blocked by a review's failed run is unblocked by a new push, whose head starts afresh, or, before taking this version, by a new review. Neither an edit nor a re-run clears it: a re-run replays the old event's payload, with the description of that time, and fails again (seen on a downstream project).

Checks

  • The workflow's test seen red first. uv run bash platform/tests/run.sh: 1294 passed before the rebase. test_pull_request.py: 102 passed after it. nstack fitness: compliant.
  • Independent verifier: nothing blocking. Diagnosis and smallest fix confirmed. Its findings are taken: a stale docstring, the register row, the migration wording.

Register row D218.

🤖 Generated with Claude Code

@napkinstack-agent
napkinstack-agent Bot requested a review from a team as a code owner November 14, 2026 15:06
A review triggered the required « Test sheet and cycle »; on an attested project a code owner
usually approves before the record is complete, so that run failed (A2). GitHub keeps it beside
the later green run of the same head and the ruleset refused the merge; the notes push that
completes the record is no event, and an agent cannot re-run a workflow (#394). The job now runs
on pull_request events only. A review or a comment is a verifier's hand read at the next run,
which any edit of the description starts — T2's message and the verification playbook say so.

Agent-Session: nstack-os-d218
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@napkinstack-agent
napkinstack-agent Bot merged commit 91c9a06 into main Nov 14, 2026
3 checks passed
@napkinstack-agent
napkinstack-agent Bot deleted the head-events-only branch November 14, 2026 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

A review-triggered run of « Test sheet and cycle » fails before the record is final and is never re-run: the merge stays blocked

1 participant