Repository navigation
D218 — the pull request check runs on the pull request's own events only - #395
Merged
Merged
Conversation
A review triggered the required « Test sheet and cycle »; on an attested project a code owner usually approves before the record is complete, so that run failed (A2). GitHub keeps it beside the later green run of the same head and the ruleset refused the merge; the notes push that completes the record is no event, and an agent cannot re-run a workflow (#394). The job now runs on pull_request events only. A review or a comment is a verifier's hand read at the next run, which any edit of the description starts — T2's message and the verification playbook say so. Agent-Session: nstack-os-d218 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
napkinstack-agent
Bot
force-pushed
the
head-events-only
branch
from
November 14, 2026 15:11
c1a7935 to
48b9e28
Compare
1 of 2 tasks
napkinstack-admin
approved these changes
Nov 14, 2026
1 of 2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #394.
Why
On an attested project, a code owner usually approves before the record is complete. The review triggered the required « Test sheet and cycle », and that run failed (A2). The record then completes by a notes push, which is no event. A later
pull_requestrun of the same head passed, yet the ruleset kept refusing the merge on the review's failed run, kept beside it: HTTP 405, BLOCKED. An agent's App cannot re-run a workflow, so only the person could unblock it.What
skeleton/.github/workflows/pull-request.yml: the job runs onpull_requestevents only, with nopull_request_reviewtrigger.traces()docstring andverification.mdsay so.if:that skips the job on a review: it leaves a required check « skipped », which GitHub counts as passed;cancel-in-progress: it never touches a completed run.Migration (for v0.29.0's notes)
nstack updatemerges the workflow. A pull request already blocked by a review's failed run is unblocked by a new push, whose head starts afresh, or, before taking this version, by a new review. Neither an edit nor a re-run clears it: a re-run replays the old event's payload, with the description of that time, and fails again (seen on a downstream project).Checks
uv run bash platform/tests/run.sh: 1294 passed before the rebase.test_pull_request.py: 102 passed after it.nstack fitness: compliant.Register row D218.
🤖 Generated with Claude Code