Repository navigation
D221 — a required record status keeps an attested pull request moving - #400
Merged
Merged
Conversation
The record holds the description's sheet (D214), so it is made after the last edit, and notes start no run: the pull request's run from before it stayed red (#399). Where the base branch's ruleset requires `nstack / local checks`, the status nstack attest posts with the record, the run leaves A1 and A2 to it. An agent's App gets Commit statuses: write. Agent-Session: nstack-os-d221 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…paged, older Apps said Agent-Session: nstack-os-d221 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
napkinstack-admin
approved these changes
Nov 14, 2026
1 of 2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #399.
Why
In an attested project (
checks: attested), the record holds the description's sheet (D214), so it is made after the description's last edit. It travels by git notes, which start no workflow run. The pull request's last « Test sheet and cycle » run is older than the record, so it stays red and the merge stays blocked. Until D218, the approval's run hid this. Since D218, only an edit of the description unblocked it (#399 lists the runs and the order of events).What
Legend: the arrows from
nstack attestare what it writes; the ruleset decides which check judges the record.pr-checkon the forge's run: if the base branch's ruleset requiresnstack / local checks, it leaves A1 and A2 to that status and says so.nstack attestalready posts that status with the record (PDR-0013 §3). The rules come fromGET /repos/{repo}/rules/branches/{base}, read with the job's token. If they cannot be read, or the status is not required, the run judges the record as before.Commit statuses: write, so an agent's record shows its status.nstack attestsays the merge waits for it.Market: a result made outside CI reaches the forge as a commit status that a ruleset requires (Jenkins, Buildkite, basecamp/gh-signoff). Making the status required stays the decider's gesture at the forge, as PDR-0013 §3 says.
Tests
test_attest.py: the run defers to the required status (no record, then a failed record); without that status, A1 fails and names both ways out; the rules are read, URL-encoded and fail safe, and only on CI. Seen red before the change.uv run bash platform/tests/run.sh: 1308 passed, scenarios OK. Fitness compliant.Migration
For an attested project on GitHub, add
nstack / local checksto the default branch ruleset's required checks: Settings → Rules → the ruleset → Require status checks. An existing agent App also needs Commit statuses: write.🤖 Generated with Claude Code