You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
capture e2e: E2 passes even if a signal-at never signals #814
In the capture e2e, scenario E2 ("kept as FLAC: killed while it compresses, and a second signal", D87) starts three e2e_measure_v2.py signal-at helpers in the background and then discards their exit status (wait … || true).
If a helper exits without sending its signal (the file it waits for never appears, or the PID is already gone), nothing in E2 fails:
The recorder stops normally on the following kill -INT.
Its folder is complete.
measure2 whole passes.
The scenario then passes without testing the interruption it is meant to test.
This gap is already on main: a bare wait discarded these statuses too. It was found while verifying #796, which keeps the same behaviour.
Oracle
Each helper's exit status is checked. A mutant signal-at that exits 1 without signalling makes E2 fail.
Today's evidence
The run's log must show the three lines "SIGTERM/SIGKILL sent as …", which signal-at prints only after it has sent the signal.
Activity