Skip to content

shell: the list of models can be rolled back to an older signed one (D56 follow-up) #826

Open

Description

@napkinstack-agent

What

Since D56 (#825), the list of models read again is refused unless its signature verifies under the decider's key. The signature's trusted comment, which holds the timestamp, is never read. So an older list, genuinely signed by the decider, is accepted again in place of a newer one. Someone who controls what Kitokey downloads, a network or a mirror for example, can then roll the list back: models removed since (withdrawn, unsafe) come back, and new ones disappear.

Found by the verifier of #825 (2026-11-14).

Prior art

TUF's timestamp and snapshot roles, and apt's Valid-Until and date checks: a signed metadata file is refused when it is older than the one already trusted.

Oracle

A list signed by a test key, with an older timestamp in its trusted comment than the list built in, or than the last one accepted, is refused and the refusal is said. A newer one is accepted. The test fails before the fix.

Size

The smallest fix: read the trusted comment's timestamp, which minisign verifies with the signature, and compare it with the built-in list's. No new metadata format.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions