Skip to content

capture: signal-at's « not sent » to a zombie recorder is held by no test #854

Open

Description

@kitokey-sam

modules/capture/scripts/e2e_measure_v2.py's signal-at (#829) must not say « sent » to a recorder that has already ended. ended(pid) reads /proc/<pid>/stat: a recorder gone, or a zombie the e2e's shell has not waited for yet, is ended. No automated check holds the zombie half.

Survivor, found by ines while verifying #829 at 0a8deaf. With ended blind to the zombie (« Z » → « never »), signal-at says SIGKILL sent as late.part appeared to a recorder that has already ended, and exits 0. E2 accepts « sent » and « not sent » alike, so the e2e stays green. That is the false « sent » #829 is written against.

What is missing: a check that runs signal-at with a zombie as its recorder, whose file appears after the recorder ended. It must say not sent: the recorder ended as … appeared and exit 0. #829's description shows this case by hand: « the file there, the recorder ended, not yet waited for ». No test keeps it.

Cheap shape: a small script beside the e2e. It starts sleep 0 as a child and does not wait for it, so it is a zombie. It creates the file, runs signal-at on that pid, and checks the sentence and the status. It runs with capture's checks, needing no PipeWire. The « Z » → « never » mutant must fail it.

Left out of #829 so that its runs, done at its head, are not all made again.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions