Skip to content

shell test: cancelled_it_ends_within_two_seconds… fails under load (3 of ~12 at load 17; 0 of 8 at load 7–9) #856

Open

Description

@kitokey-ines

modules/shell/tests/transcription.rs::cancelled_it_ends_within_two_seconds_with_what_it_started_even_deaf_to_term fails intermittently when the machine is loaded.

Seen

Run alone (cargo test --locked --test transcription cancelled_it_ends_within_two_seconds) on the team's workstation, 2026-11-15:

Head Load average (1 min) Failed
ba13696 (#847) about 17 (attests running in parallel) 3 of about 12
ba13696 (#847) 7–9 0 of 8
f3a35b7 (main) 7–9 0 of 8

#847 changes no code this test runs: its diff touches providers.rs, main.rs, words.rs and window.js, not the making nor its cancel. Not measured: main at load 17.

Not known: which bound gave way. The test has two (tests/transcription.rs:343, said.recv_timeout(Duration::from_secs(2)), and :346, pressed.elapsed() <= Duration::from_secs(2)), and the failing runs' messages were not kept.

Why it matters

The 2 s is not a test margin: it is D92's criterion — « Annuler » ends any making within two seconds (1d6ee69). A raised constant would stop testing the promise. Under load, either the product misses its promise or the test measures more than the product's part of it; which of the two is the first question.

Prior art for the fix

  • A bound proportional to a measure of the machine, taken in the same run: for example, the time the test's own child takes to start, as a scale for what the product is allowed.
  • A time budget read from the test's configuration, set wider on a loaded runner and kept at 2 s where the promise is judged.
  • Never a raised constant alone.

Before choosing, keep the failure's message on a loaded run, to know which bound gave way.

Proposed owner: marc (transcription's making, #845/#846). The test is in modules/shell.

Activity

  1. changed the title [-]shell test: cancelled_it_ends_within_two_seconds… fails under load (3 of ~12 at load 17, 0 of 8 at 7–9, main alike)[/-] [+]shell test: cancelled_it_ends_within_two_seconds… fails under load (3 of ~12 at load 17; 0 of 8 at load 7–9)[/+] on Nov 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions