You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
shell: WITHOUT_COMMENT fails when the count goes down, turning main red on parallel merges #857
modules/shell/tests/words.rs's every_sentence_carries_its_comment fails both ways. More sentences without the guide's comment than WITHOUT_COMMENT fails (« written without its comment »), which is the ratchet's purpose. Fewer also fails (« lower it »). The second half turns main red whenever two pull requests merge in parallel, each with the count it was written against.
Seen: main at c7e344f is red. The test counts 600 against 602, because pull requests merged meanwhile took sentences out. Each merger then recomputes the number by hand. #813 fixes it for now by setting 580.
Prior art: a baseline only fails when it worsens.
ESLint's and Psalm's baselines report entries that are no longer needed, but do not fail on them by default; Psalm has a flag to update the baseline.
Coverage thresholds fail below the floor, never above it.
The number is lowered when someone chooses to, and the tool says by how much.
Shape proposed:
every_sentence_carries_its_comment fails only when the count is above WITHOUT_COMMENT, naming the sentences as today.
At or below it, the test passes. When below, it prints « WITHOUT_COMMENT can be lowered to N » on the test's output. It shows with --nocapture, and in the run's log where the checks keep it.
Optionally, a check outside cargo test (a fitness function, or the attest's own) says the same on a pull request, so the lowering is offered at review and never forced at merge.
Same pattern, to read: tests/words_still_wrong.txt's keyed rules fail on « listed and put right ». Two pull requests rewording the same listed sentence in parallel would collide the same way. That is rarer, since it is by key, not by count. Whether to relax it the same way is a choice for the list's owner (D94).
Out of scope: the counted comments themselves, D94 part 2's.
Activity
shell: test — the sentences without their comment are a baseline that…