Skip to content

shell: the list's signature asked once more when its connection is cut before any answer (D56) #869

Open

Description

@kitokey-lina

What

When the models' list is read again (« Mettre à jour la liste », D40, D56), registry::fetch asks for the list and then for its signature, on one ureq agent. If the connection is cut between them (io: Peer disconnected), the read is refused and the page says the list could not be updated. A second try would most likely have read it.

Seen in the e2e (#866): its stand-in, in HTTP/1.0, closed each connection without saying so, and the signature's request went out on the connection just closed. The stand-in now says « Connection: close ». A real network, or a proxy, can still cut a connection that is reused.

Proposal (after the freeze)

Retry the signature's request once when the connection was cut before any answer came, then refuse as today. It is a GET with no side effect, and the list it signs is already in hand. Nothing else is retried: an HTTP error, a signature that does not verify, or a list over its limit stays refused at once.

Oracle

tests/registry_fetch.rs: a server that cuts the first connection the signature is asked on, then answers. The list is taken after one retry, and with two cuts it is refused, saying why.

From the coordinator's remark on #866, 2026-11-15.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions