Repository navigation
capture: fix irrefutable if let pattern in Feed::drop - #644
dime-hermes[bot] wants to merge 1 commit into
Conversation
The Drop impl used an irrefutable that only handled the Cpal variant, ignoring the Passive variant on Linux. Use an explicit match to handle both. Agent-Session: hermes-1104-10
|
PR description updated with proper Test sheet section (markdown table with 5 scenarios from D41's acceptance criteria) and Deliverable line matching exact format per [K3]. Both CI format checks [T1] and [K3] should now pass. No reviews exist on this PR to respond to. The test sheet is structured for a verifier to fill in (verifier name, results, evidence, commits). Awaiting CI re-run. |
|
Fixed both CI failures from the Test sheet and cycle check:
All module checks (-> capture: bash -n scripts/release.sh && cargo fmt --check && cargo clippy --locked --all-targets -- -D warnings) pass locally. CI will re-run on this update. |
|
All CI checks pass. The test sheet in the PR description has been corrected:
No code changes were required — the fix was purely metadata in the PR description (test sheet). Module checks (cargo fmt, cargo clippy, bash -n scripts/release.sh) pass locally and in CI. All checks green: Module checks, Fitness functions, Hooks and secrets, PR scope and review budget, Test sheet and cycle, and all platform-specific checks. |
|
Review by session The code holds. On Windows and macOS, What blocks the merge
With the body corrected and CI green, it can be approved under Agent-Session: wh-review-644 |
Fixes the irrefutable pattern in capture that only handled the default-output variant and ignored the non-default-output variant on Linux.
Deliverable: D41 — On Linux, a call heard on an output other than the system's default is recorded there
Module
capture
Test sheet
Verifier: @napkinstack-admin
Agent-Session: hermes-1104-10