Repository navigation
D92 — shell: a meeting made after a stop is told once, naming it, and only where no window of Kitokey has the focus - #824
Open
kitokey-marc[bot] wants to merge 22 commits into
Conversation
…the page gives an estimate and Cancel, and one notification says it is ready Agent-Session: 14f73956-90b9-46a3-9fcc-52dc45c43948
…(BE) Scenario BE, criterion 4 of D92: a transcript and minutes made again with a first model, held by the played programs — each with a child deaf to TERM —, « Annuler » on the meeting's page: both processes gone and the shell idle within two seconds, the version already whole kept byte for byte with nothing beside it, the page saying what was stopped, no notification; then a second model started at once, the version shown naming it. A first transcript cancelled leaves nothing to be taken up; the next model makes it whole. Fails today: no « Annuler » on the page. Agent-Session: 14f73956-90b9-46a3-9fcc-52dc45c43948 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ole version kept (D92) The meeting's page offers « Annuler » while its transcript or its minutes are made, or wait their turn. The program is stopped as a group: TERM, a second's grace, then KILL to what is left — the summary's program now leads a group of its own, as the transcript's did. A cancelled making is no failure: nothing told, no notification, nothing made after it; the page says it stopped, and its button to make it again is offered. A redo's earlier transcript is put back, the minutes there were never replaced; a first transcript cancelled leaves nothing to be taken up by another model. Agent-Session: 14f73956-90b9-46a3-9fcc-52dc45c43948 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…by a test (D92) The verifier's review of 6dac438. A mark is now by meeting and kind, set by « Annuler » only under its kind's lock while that making runs for the meeting, and taken under the same lock as it ends or begins: a cancel between the start's two steps is no longer erased, and one pressed after the end no longer marks a later making — of the other kind least of all, a first transcript's failure taken for a cancel and its file removed. A meeting taken from a line and not yet begun is said taken; « Annuler » withdraws it there and its start begins nothing. A test holds the group told TERM first, a child ending by it within the grace. Agent-Session: 14f73956-90b9-46a3-9fcc-52dc45c43948 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ted (D92) The verifier's second review of the same piece found a third window between two locks: marks set by « Annuler » and read by a making's start and end could still be lost or left. The field's convention replaces them — Go's context, tokio's CancellationToken, .NET's: each making owns one token from the line to its end, cancelled, or holding its running program, under one lock. « Annuler » cancels the meeting's tokens — in a line, taken from it, being made —; a start begins nothing once cancelled, and holds its program, stopped at once if cancelled since; an end is « cancelled » by its own token alone. No mark, no set by meeting. tests/cancel.rs holds the token's three orders and a cancel racing the hold. Agent-Session: 14f73956-90b9-46a3-9fcc-52dc45c43948 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…llows it (D92) The decider's case, as the coordinator settled it: Annuler is pressed to change the model. A transcript its program wrote all the same is whole and kept, shown as written — never said stopped —, but no notification is sent and no minutes are made after it with the model being changed, whatever `after` says. The same for minutes written after a cancel: kept, nothing told. BE holds it: the played program finishing on TERM, the settings chaining the minutes, none made and nothing notified. Agent-Session: 14f73956-90b9-46a3-9fcc-52dc45c43948 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…uilt (AL) AL now asks, of a meeting made after a stop: nothing told while a window of Kitokey has the focus; with another application's window in front, one notification naming the meeting — the minutes', or the failure's —, never « Transcription prête » on its own before them; its click opens the page. Agent-Session: 14f73956-90b9-46a3-9fcc-52dc45c43948 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ow of Kitokey has the focus (D92) The end of a meeting's making — the transcript when no minutes follow, else the minutes, written or failed — is told by one notification, its meeting named first: its title, else its hour that day, else its day and hour, by one formatter in words.rs (CLDR's abbreviated months, as the window's Intl). A window of Kitokey with the focus: nothing told, its page says it. A transcript made again with its minutes after: theirs alone. AL's precondition met in app_language too: its notifications awaited with another application in front. Agent-Session: 14f73956-90b9-46a3-9fcc-52dc45c43948 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…s other gestures say theirs (D92) tests/silence.rs refused a command that fails without a word: the cancel's failure — its meeting gone meanwhile — now says it where its making is said, and the button is given back. Agent-Session: 14f73956-90b9-46a3-9fcc-52dc45c43948 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…of a meeting made after a stop (D92) A transcript written with its minutes to follow is not told: when they cannot start — nobody named, no provider, an agreement asked, no whole transcript —, D25's notice is the one notification, and now names the meeting. Told as D25 says, the focus aside. AL's fourth step holds it. Agent-Session: 14f73956-90b9-46a3-9fcc-52dc45c43948 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…nder, relayed or not, title and body (D92) At 397a654 the three checks failed with a text that names the meeting: the tail of the monitor's text did not say whether the count or a transcript's notification failed them. Each Notify seen is now listed. Agent-Session: 14f73956-90b9-46a3-9fcc-52dc45c43948 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
window.js, and #807's own lines of main.rs, words.rs and e2e_window.py, taken from main: #807's last head. D92 c3's lines kept beside them: the meeting named in words.rs' tests, and the Settings check of D95 followed by c3's own « away » before the transcript is made again. Agent-Session: 14f73956-90b9-46a3-9fcc-52dc45c43948 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… kept (D92) `for_meeting` returns a notification: named in `NOTIFYING` and each notice read again through it. Agent-Session: 14f73956-90b9-46a3-9fcc-52dc45c43948 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…tices only where Kitokey is not in front (D92) D25's notices for minutes that cannot start, and a transcript whose model or program is missing, go through the one path that names the meeting and holds back while a window of Kitokey has the focus: criterion 3's « none when one has ». AL now makes each case through a stop — the page's own click, which moves no focus —, a redo kept for its own path: the minutes ready and clicked, made again, a titled meeting's failed minutes named by its title, no model, no transcription program, no one to write the minutes; that last one again with Kitokey in front, nothing told and Settings opened. Agent-Session: 14f73956-90b9-46a3-9fcc-52dc45c43948 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
4 tasks
… named by its minutes Two scenarios said « AL. » on main: meeting_named (D48) and meeting_told_once (D92). The second takes BN, free (BM is #844's, BL press_on_the_page_left). The print and the docstring alone: no MANIFEST line names it. Agent-Session: 14f73956-90b9-46a3-9fcc-52dc45c43948 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…meeting-is-made Agent-Session: 14f73956-90b9-46a3-9fcc-52dc45c43948 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…s reader looks (D92)
`day`, `hour`, `meeting` and `for_meeting`: Shows, When, At most and Placeholders, inside each
body, `for_meeting`'s moved there and its placeholder named as its sentence writes it,
{meeting}. With them, the sentences without their comment are main's own: 600, against the
602 #812 left — `WITHOUT_COMMENT` lowered, as the test asks (red on main as it is).
Agent-Session: 14f73956-90b9-46a3-9fcc-52dc45c43948
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…meeting-is-made The comment ratchet now fails only on an increase: main's WITHOUT_COMMENT kept, 597. Both sides of tests/words.rs kept otherwise: D92's tests of `day`, `hour`, `meeting`, and `for_meeting` read in `NOTIFYING` and `every_notice`. Agent-Session: 14f73956-90b9-46a3-9fcc-52dc45c43948 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…meeting-is-made The e2e finds a start's tray item in a second: this branch's attest saves about 20 minutes. Agent-Session: 14f73956-90b9-46a3-9fcc-52dc45c43948 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…meeting-is-made main.rs: a settings file refused, the minutes not started — #813's refusal (`why.detail` to the line kept for the log, `why.refused` said) told by #824's path, naming the meeting where Kitokey is not in front. tests/words.rs: both sides' tests kept. Agent-Session: 14f73956-90b9-46a3-9fcc-52dc45c43948 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…and BN counts Kitokey's own notifications (D92) Criterion 3 and its D25 notices: nothing notified while a window of Kitokey has the focus, the window saying it there. Four older checks asked a notification of a making started from its page, the window in front: the minutes made again that fail, the cause they name, the redo through the agreement, the first meeting with no one chosen. They now ask none, the page or Settings saying it. BN counted every Notify on the bus: the desktop relays a notification once more, from its own connection (`x-shell-sender`), which it counted twice. It now counts those Kitokey sent. Agent-Session: 14f73956-90b9-46a3-9fcc-52dc45c43948 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
D92 — shell: a meeting made after a stop is told once, naming it, and only where no window of Kitokey has the focus
Refs #769 — D92 closes once its four criteria hold; this pull request takes criterion 3.
Module
modules/shell— exactly one.cross-modulelabel is required, justification belowDeliverable
Deliverable: D92 of cycle 10 (
docs/project/cycles/10-kitokey-ready-when-you-come-back.md), criterion 3: « Given a meeting made after a stop, when its last step ends — written or failed —, then exactly one notification is sent for it, and only when no window of Kitokey has the focus — none when one has —, naming the meeting, a click opening its page; « Transcription prête » is no longer sent on its own when a summary follows ». Criterion 4 merged with #807.What it changes
window_focusedasks the toolkit whether the main or the small window has it. When one does, nothing is sent (shell.made_not_toldin the log): the page says it there. This follows GNOME's HIG, as the cycle cites it: a notification is for an event while the user is in another application.words.rs, with CLDR's abbreviated months, as the window'sIntlwrites them.NoModel,NoTranscriber): the same path, the meeting named, nothing sent while Kitokey has the focus.Minutes::Waiting), Ollama waited for (OllamaWaits) — then, once given, the minutes'. They are two events: the first asks the user to act, the second says the meeting is made.words.rs.for_meetingis named in D94's title test and each notification is read again through it: the title is unchanged, so it still holds 50 characters.Oracle
scripts/e2e_window.py(lettered AL until 6e8d557, a letter main's D48 scenario holds too) (3934563 for steps 1 to 3, then step 4).transcribe), made by the page's own click, which moves no focus; the meeting before it is moved out of the list. One redo (context_redo) is kept, for its own branch: the minutes after it, their notification alone. Added: a titled meeting (title.txt) named by its title, no model, no transcription program (each with what to do), and step 4 again with Kitokey in front — nothing told, Settings opened.Notifywas sent anyway;Notifyseen when a check fails: its sender, whether it was relayed, its title and its body. Its AL run is queued; the coordinator moves it to this head if it has not run.Kind of oracle: end-to-end, the window's e2e on played engines, reading the session bus's notifications. It needs a window, which this session's sandbox does not open.
Review budget
Contracts
Definition of Done
cargo fmt --check,cargo clippy --all-targets -D warnings,python3 -m py_compile scripts/e2e_window.pytests/words.rs.for_meeting. It was seen failing with the function left out ofNOTIFYING.tests/migrate.rs::a_model_written_from_home_is_named_where_it_went. It writes in$HOME, which this sandbox refuses; the same happens onmain, and shell: the test of a model written from the home uses a home of its own #819 fixes it.words.rsTest sheet
Verifier: session 92ded11e-58ef-492d-ba56-c820b9011de8
context_redo), the sametests/words.rs: given a meeting's title, or its start only, when it is named, then: the title in quotes; else « la réunion de 12:00 » that day; else « la réunion du 18 oct. à 12:00 »; in both languages; the notification's title unchangedcargo test --locked --test words:51 passed; 0 failed. Five mutants, each applied alone (git diff --numstat1 1 or 1 2), then restored, each killed by one test:for_meetingleaving the body as it was (the_notification_that_ends_a_meeting_names_it_first_and_keeps_its_title); « that day » inverted in French and a title of blanks kept (a_meeting_is_named_by_its_title_else_its_hour_that_day_else_its_day_and_hour); the English hour on one digit,%l(a_day_and_an_hour_are_said_as_the_window_says_them);for_meetingtaken out ofNOTIFYING(a_notification_s_title_holds_50_characters). The window's formatter,Intl.DateTimeFormatwithhour: "2-digit"andmonth: "short"(node, ICU 78.3):09:42 AM,05:31 PM,12:05 AM,18 oct.,00:05, aswords::dayandhoursay themVerifier's remarks: read at 6c3c6be; S1 to S4 wait for the coordinator's AL run at the head.
context_redo), which goes throughretranscribeand itsminutes_afterbranch. Only step 1 is made after a stop (transcribe), and with the focus in Kitokey. So the newtell_madecalls intranscribe(a transcript with no minutes to follow,after = "transcript", and a transcript failed) run in no scenario with the focus elsewhere. S2 to S4 say « given the same »: if they are run as written, they hold for a meeting made again, not one made after a stop.Minutes::Waiting) or Ollama is waited for (OllamaWaits), its notice names the meeting, and the minutes written afterwards are told again. That is one meeting with two notifications, against criterion 3's « exactly one ». It may be intended, since the agreement asks for a gesture. No scenario covers it.NoModel(l.4111) andNoTranscriber(l.4129) are sent with plaintell: the meeting is not named, and the focus is not looked at.of_meeting's title, fromnamed::reador elseminutes::title, is not run: AL's meeting has none, andtests/words.rscallswords::meetingdirectly.tests/words.rsthen fails twice:every_sentence_carries_its_comment: 624 sentences have no comment, against 602 allowed. The 22 new ones areday,hour,meetingandfor_meeting.for_meeting's comment sits above itsfn, and D94 — shell: the tests read every sentence of words.rs against the voice guide #812's parser takes a function's comment only from inside its body, so it is not counted. Whichever pull request merges second must move it into the body, or raise the count.no_sentence_says_a_word_the_lexicon_refuses:window.minutes_stopped(« Minutes stopped… », from D92 — shell: « Annuler » ends any making from a meeting's page within two seconds, the whole version kept, another model at once #807 onmain). That one is D94 — shell: the tests read every sentence of words.rs against the voice guide #812's to fix, not this pull request's.Summary
DONE
tell_made: the end of a meeting's making is told once, naming the meeting, only when no window of Kitokey has the focus.words::day,hour,meetingandfor_meeting: one way to name a meeting, in both languages.VERIFIED
py_compile; pre-commit's hooks.tests/words.rs: 51 passed.main.py_compile; ruffF,PLW2901finds nothing in it (the 7 findings left are shell: the e2e scripts pass ruff's F and PLW2901, before the hook that holds them to it #820's).ASSUMED
is_focusedis the desktop's focus. BN holds it on Linux only.NOT VERIFIED
RISKS
Signals to report
🤖 Generated with Claude Code