Repository navigation
ci: the Windows app is built on a pull request that changes capture or transcription - #832
Merged
Merged
Conversation
…r transcription Both link C or C++ into their programs under +crt-static — libFLAC, whisper.cpp —, which windows.yml does not build with: #794's LNK2019 was seen only by a run asked by hand, twice, and #787, #796, #810, #829 had no run of it. Shell and summary are Rust alone, compiled by windows.yml on every change, and keep out of it. Agent-Session: 14f73956-90b9-46a3-9fcc-52dc45c43948 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ci: the Windows app is built on a pull request that changes capture or transcription
Module
None:
.github/workflows/windows-app.yml, a code owners path, approved by the decider. Pushed from the decider's account: an agent's App may not write workflows.cross-modulelabel is required, justification belowDeliverable
Out of cycle: the coordinator's request of 2026-11-14, agreed by the decider. #794's link error (libFLAC,
LNK2019under+crt-static) was seen only through « Windows — the zip and the package » runs started by hand, twice.What it changes
pull_requestfilter ofwindows-app.ymlgainsmodules/capture/**andmodules/transcription/**, with the reason on the line above them.windows-app.ymlbuilds them under+crt-static, the static C runtime the zip and the package hold, andwindows.ymldoes not use that flag. A link error that only+crt-staticcauses is therefore seen nowhere on a pull request today.windows.ymlcompiles and tests them on every change, so the Windows minutes stay where they tell something, as the file's header asks. Their packaging goes throughinstall, which the filter already covers.pushfilter onmainis unchanged.ci/windows-builds-with-crt-static, which would have builtwindows.ymlwith+crt-static, is abandoned. capture: libFLAC compiled with the static MSVC runtime under +crt-static #794 settles libFLAC's runtime in capture's own build (cmake/msvc-runtime.cmake), where it belongs.Oracle
modules/capture/**(ormodules/transcription/**) alone runs « Windows — the zip and the package ».windows-apprun on a pull request event for the recent pull requests that change capture or transcription.workflow_dispatchruns, started by hand: 43587655350 at ba91ae8 and 43616667039 at 2ab82d0.Kind of oracle: the forge's checks on a pull request.
Review budget
Contracts
Definition of Done
yaml.safe_load: the four paths listed), and the repository's pre-commit hooks passed at commitSummary
DONE
windows-app.ymlruns on a pull request that changes capture or transcription, the two programs that link C or C++ under+crt-static.VERIFIED
mainmerged in by the decider: Windows — the zip and the package green with capture: libFLAC compiled with the static MSVC runtime under +crt-static #794's runtime fix.ASSUMED
Cargo.toml:libflac-sysin capture,whisper-rsin transcription, nothing of the kind in shell or summary).NOT VERIFIED
RISKS
Signals to report
pathschecked against the modules its jobs build🤖 Generated with Claude Code