Skip to content

ci: the Windows app is built on a pull request that changes capture or transcription - #832

Merged
napkinstack-agent[bot] merged 2 commits into
mainfrom
ci/windows-app-capture
Nov 15, 2026
Merged

napkinstack-agent[bot] merged 2 commits into
mainfrom
ci/windows-app-capture

Conversation

@napkinstack-admin

@napkinstack-admin napkinstack-admin commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

ci: the Windows app is built on a pull request that changes capture or transcription


Module

None: .github/workflows/windows-app.yml, a code owners path, approved by the decider. Pushed from the decider's account: an agent's App may not write workflows.

  • This pull request touches a single module
  • ⚠️ Cross-module — the cross-module label is required, justification below

Deliverable

Out of cycle: the coordinator's request of 2026-11-14, agreed by the decider. #794's link error (libFLAC, LNK2019 under +crt-static) was seen only through « Windows — the zip and the package » runs started by hand, twice.

What it changes

  • The pull_request filter of windows-app.yml gains modules/capture/** and modules/transcription/**, with the reason on the line above them.
  • Why these two. Both link C or C++ into their programs: libFLAC in capture, whisper.cpp in transcription. windows-app.yml builds them under +crt-static, the static C runtime the zip and the package hold, and windows.yml does not use that flag. A link error that only +crt-static causes is therefore seen nowhere on a pull request today.
  • Why not shell and summary. They are Rust alone, with no C or C++ of their own linked. windows.yml compiles and tests them on every change, so the Windows minutes stay where they tell something, as the file's header asks. Their packaging goes through install, which the filter already covers.
  • The header comment says the new rule, and the push filter on main is unchanged.
  • ci/windows-builds-with-crt-static, which would have built windows.yml with +crt-static, is abandoned. capture: libFLAC compiled with the static MSVC runtime under +crt-static #794 settles libFLAC's runtime in capture's own build (cmake/msvc-runtime.cmake), where it belongs.

Oracle

Kind of oracle: the forge's checks on a pull request.


Review budget

  • Lines changed (excluding generated): 9 (7 added, 2 removed)
  • Files touched: 1
  • Within budget

Contracts

  • No contract affected

Definition of Done

  • Oracle green: the next capture-only pull request, after the merge
  • Lint, format, types: the file parses (yaml.safe_load: the four paths listed), and the repository's pre-commit hooks passed at commit
  • Unit tests: not applicable
  • Affected documentation updated: the workflow's header
  • Diff self-reviewed line by line

Summary

DONE

  • windows-app.yml runs on a pull request that changes capture or transcription, the two programs that link C or C++ under +crt-static.

VERIFIED

ASSUMED

  • No other module links C or C++ into a program (Cargo.toml: libflac-sys in capture, whisper-rs in transcription, nothing of the kind in shell or summary).

NOT VERIFIED

  • The run on the next capture-only pull request: it comes after the merge.

RISKS


Signals to report

  • I had to look at another module's implementation
  • A kernel or playbook rule got in my way for no good reason
  • A quality gate blocked without improving quality
  • A rule applied by hand would be worth automating: a workflow's paths checked against the modules its jobs build

🤖 Generated with Claude Code

…r transcription

Both link C or C++ into their programs under +crt-static — libFLAC, whisper.cpp —, which
windows.yml does not build with: #794's LNK2019 was seen only by a run asked by hand, twice,
and #787, #796, #810, #829 had no run of it. Shell and summary are Rust alone, compiled by
windows.yml on every change, and keep out of it.

Agent-Session: 14f73956-90b9-46a3-9fcc-52dc45c43948
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@napkinstack-admin
napkinstack-admin requested a review from a team as a code owner November 14, 2026 17:02
@napkinstack-admin napkinstack-admin added the out-of-cycle Work outside the current cycle: an incident, a production defect; justified in the PR label Nov 14, 2026
@napkinstack-agent
napkinstack-agent Bot merged commit cdf444b into main Nov 15, 2026
6 of 7 checks passed
@napkinstack-agent
napkinstack-agent Bot deleted the ci/windows-app-capture branch November 15, 2026 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

out-of-cycle Work outside the current cycle: an incident, a production defect; justified in the PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant