Skip to content

shell: the transcription's settings show one « Enregistrer » and one agreement at a time, saving what the page shows (#860) - #870

Merged
napkinstack-agent[bot] merged 2 commits into
mainfrom
shell/one-save
Nov 15, 2026
Merged

napkinstack-agent[bot] merged 2 commits into
mainfrom
shell/one-save

Conversation

@kitokey-lina

@kitokey-lina kitokey-lina Bot commented Nov 15, 2026 •

Copy link
Copy Markdown
Contributor

Module

modules/shell: ui/window.js, scripts/e2e_window.py.

  • This pull request touches a single module

Deliverable

Out of cycle: #860, the second of the two Settings pull requests that follow D95 (the coordinator's decision of 2026-11-15, the decider's batch), the save path. Closes #860.

What it changes

In Settings, « Transcription », with a service chosen and « Avancé » unfolded, the page showed two agreements and two « Enregistrer »: the service's (transcription-agreed, transcription-save) and « Avancé »'s (transcription-own-agreed, transcription-own-save). Nothing said which one counted.

Convention: one save per setting, as macOS's and GNOME's settings have it.

  • One at a time. With « Avancé » folded, the service's « Enregistrer » and agreement are shown. Unfolded, « Avancé »'s alone, the service's hidden.
  • That one saves what the page shows. The address is the one typed, or else the service chosen above. The model is the one typed, or else, for that service, the one chosen in its list. Before, « Avancé »'s « Enregistrer » with no model typed refused to save, even with a model chosen in the list just above.
  • The agreement still names its host, and none is asked for this computer (shell: Settings ask to agree to send the sound to this computer (127.0.0.1), where no agreement is owed #859).

Capability removed: none. Both ways of saving remain, one shown at a time.

Oracle

Review budget

  • Within budget: 2 files, +36 −5 at 67422a6.

Test sheet

Verifier: session bfdb23f1-1199-4cda-ab11-22e178326643

# Given · when · then Kind Result Evidence Commit Confirmed
T1 Given « Transcription » with a service listed, when « Avancé » is unfolded, then one « Enregistrer » and at most one agreement are shown; nothing typed, that « Enregistrer » saves the service chosen above with the model chosen in its list: Z automated passed The attest's full shell e2e at 67422a6 (evidence-870/e2e.txt, audit.json commit 67422a6, verdict passed; 1836 ok, 0 FAIL, « e2e: passed »; read by me), Z: « « Avancé » unfolded: one « Enregistrer » shown, one agreement at most (#860) », « nothing typed under « Avancé »: that « Enregistrer » saves the service chosen above, the model chosen in its list (#860) » ok. Red at 500f8d4, the test alone (partial-r860red-e2e.txt, head in queue-wS1.log): the first FAIL, every other check of Z ok; green at 67422a6, Z and BG alone (partial-r860green-e2e.txt). 67422a6 —
T2 Given a host elsewhere typed under « Avancé », when it shows, then its own agreement alone is shown: BG automated passed The attest's full shell e2e at 67422a6 (evidence-870/e2e.txt, audit.json commit 67422a6, verdict passed; 1836 ok, 0 FAIL, « e2e: passed »; read by me), BG: « a host elsewhere typed under « Avancé »: one agreement shown, its own (#860) » ok. 67422a6 —
T3 Given the head with the service's « Enregistrer » shown again while « Avancé » is unfolded (the mutant above), when Z runs, then it fails automated passed The coordinator's run through the queue (queue.log 16:26, worker S1), Z alone: partial-r860mut3.head, written by partial.sh itself, « head at start 67422a6 · diff 1 1 modules/shell/ui/window.js · bfe736e3e226 »; partial-r860mut3-e2e.txt: « « Avancé » unfolded: one « Enregistrer » shown, one agreement at most (#860) » FAIL, got [['transcription-save', 'transcription-own-save'], []], 46 ok, « FAILED » — killed. The diff checked by me: saveService.hidden = !listedShown || open; → saveService.hidden = !listedShown; applied at 67422a6 in my copy gives the same numstat and, its blobs abbreviated to 8, the same sha256 prefix bfe736e3e226. 67422a6 —
T4 Given the head, when the full e2e runs, then it passes automated passed The attest's full shell e2e at 67422a6 (evidence-870/e2e.txt, audit.json commit 67422a6, verdict passed; 1836 ok, 0 FAIL, « e2e: passed »; read by me). 67422a6 —

Verifier's remarks:

Summary

  • DONE: one « Enregistrer » and one agreement at a time in the transcription's settings, saving what the page shows.
  • VERIFIED at 67422a6: node --check ui/window.js, python3 -m py_compile scripts/e2e_window.py; cargo test --no-fail-fast: all pass but tests/migrate.rs a_model_written_from_home_is_named_where_it_went, which fails only in the author's sandbox ($HOME read-only), as on main.
  • VERIFIED by the coordinator: the red at 500f8d4, the green alone and the mutant killed at 67422a6, above.
  • Attested 5/5 at 67422a6 (nstack 0.29.0), the coordinator's record: the full e2e green at the head; the sheet filled by the verifier.
  • RISKS: with « Avancé » unfolded, the service's model list stays shown above while « Avancé »'s « Enregistrer » saves it only when no model is typed. A model typed takes precedence, as the field under « Avancé » says.

🤖 Generated with Claude Code

kitokey-lina Bot and others added 2 commits November 15, 2026 15:25
…egistrer » and one agreement at most, saving what the page shows (#860), the oracle alone

Z: « Avancé » unfolded beside a service listed, one « Enregistrer » and at most one agreement are
shown; nothing typed under it, that « Enregistrer » saves the service chosen above with the model
chosen in its list. BG: a host elsewhere typed under « Avancé » shows its own agreement alone.

Agent-Session: 04463b35-db3b-47ea-bef5-6892f2baedb7
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…agreement at a time, saving what the page shows (#860)

« Avancé » unfolded beside a service listed showed two agreements and two « Enregistrer », nothing
saying which counted. Folded, the service's are shown; unfolded, « Avancé »'s alone, the service's
hidden. That one saves what the page shows: the address typed or else the service chosen above, the
model typed or else, that service's, the one chosen in its list.

Agent-Session: 04463b35-db3b-47ea-bef5-6892f2baedb7
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kitokey-lina kitokey-lina Bot added the out-of-cycle Work outside the current cycle: an incident, a production defect; justified in the PR label Nov 15, 2026
@napkinstack-agent
napkinstack-agent Bot merged commit 6f9ca80 into main Nov 15, 2026
14 of 20 checks passed
@napkinstack-agent
napkinstack-agent Bot deleted the shell/one-save branch November 15, 2026 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

out-of-cycle Work outside the current cycle: an incident, a production defect; justified in the PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

shell: « Avancé » unfolded shows a second agreement and a second « Enregistrer » for the transcription, without saying which counts

0 participants