Repository navigation
shell: the transcription's settings show one « Enregistrer » and one agreement at a time, saving what the page shows (#860) - #870
Merged
Conversation
…egistrer » and one agreement at most, saving what the page shows (#860), the oracle alone Z: « Avancé » unfolded beside a service listed, one « Enregistrer » and at most one agreement are shown; nothing typed under it, that « Enregistrer » saves the service chosen above with the model chosen in its list. BG: a host elsewhere typed under « Avancé » shows its own agreement alone. Agent-Session: 04463b35-db3b-47ea-bef5-6892f2baedb7 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…agreement at a time, saving what the page shows (#860) « Avancé » unfolded beside a service listed showed two agreements and two « Enregistrer », nothing saying which counted. Folded, the service's are shown; unfolded, « Avancé »'s alone, the service's hidden. That one saves what the page shows: the address typed or else the service chosen above, the model typed or else, that service's, the one chosen in its list. Agent-Session: 04463b35-db3b-47ea-bef5-6892f2baedb7 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Module
modules/shell:ui/window.js,scripts/e2e_window.py.Deliverable
Out of cycle: #860, the second of the two Settings pull requests that follow D95 (the coordinator's decision of 2026-11-15, the decider's batch), the save path. Closes #860.
What it changes
In Settings, « Transcription », with a service chosen and « Avancé » unfolded, the page showed two agreements and two « Enregistrer »: the service's (
transcription-agreed,transcription-save) and « Avancé »'s (transcription-own-agreed,transcription-own-save). Nothing said which one counted.Convention: one save per setting, as macOS's and GNOME's settings have it.
Capability removed: none. Both ways of saving remain, one shown at a time.
Oracle
partial-r860red-e2e.txt): « FAIL « Avancé » unfolded: one « Enregistrer » shown, one agreement at most (shell: « Avancé » unfolded shows a second agreement and a second « Enregistrer » for the transcription, without saying which counts #860) », got[['transcription-save', 'transcription-own-save'], []]. The next check passed there: the service's « Enregistrer », pressed, saved the list's model.partial-r860green-e2e.txt): the three checks of shell: « Avancé » unfolded shows a second agreement and a second « Enregistrer » for the transcription, without saying which counts #860 ok, their checks passed.saveService.hidden = !listedShown;in place of!listedShown || open), at 67422a6 (partial-r860mut-e2e.txt): killed, the same FAIL, got[['transcription-save', 'transcription-own-save'], []].Review budget
Test sheet
Verifier: session bfdb23f1-1199-4cda-ab11-22e178326643
evidence-870/e2e.txt,audit.jsoncommit 67422a6, verdict passed; 1836ok, 0FAIL, « e2e: passed »; read by me), Z: « « Avancé » unfolded: one « Enregistrer » shown, one agreement at most (#860) », « nothing typed under « Avancé »: that « Enregistrer » saves the service chosen above, the model chosen in its list (#860) »ok. Red at 500f8d4, the test alone (partial-r860red-e2e.txt, head inqueue-wS1.log): the first FAIL, every other check of Zok; green at 67422a6, Z and BG alone (partial-r860green-e2e.txt).67422a6evidence-870/e2e.txt,audit.jsoncommit 67422a6, verdict passed; 1836ok, 0FAIL, « e2e: passed »; read by me), BG: « a host elsewhere typed under « Avancé »: one agreement shown, its own (#860) »ok.67422a6queue.log16:26, worker S1), Z alone:partial-r860mut3.head, written bypartial.shitself, « head at start 67422a6 · diff 1 1 modules/shell/ui/window.js · bfe736e3e226 »;partial-r860mut3-e2e.txt: « « Avancé » unfolded: one « Enregistrer » shown, one agreement at most (#860) » FAIL, got[['transcription-save', 'transcription-own-save'], []], 46ok, « FAILED » — killed. The diff checked by me:saveService.hidden = !listedShown || open;→saveService.hidden = !listedShown;applied at 67422a6 in my copy gives the same numstat and, its blobs abbreviated to 8, the same sha256 prefixbfe736e3e226.67422a6evidence-870/e2e.txt,audit.jsoncommit 67422a6, verdict passed; 1836ok, 0FAIL, « e2e: passed »; read by me).67422a6Verifier's remarks:
Summary
node --check ui/window.js,python3 -m py_compile scripts/e2e_window.py;cargo test --no-fail-fast: all pass buttests/migrate.rsa_model_written_from_home_is_named_where_it_went, which fails only in the author's sandbox ($HOMEread-only), as on main.🤖 Generated with Claude Code