Repository navigation
Conversation
…penStudio-HPXML into ghp_standard_improvements
…o ghp_standard_improvements
shorowit
reviewed
Oct 9, 2026
shorowit
left a comment
shorowit
left a comment
Contributor
There was a problem hiding this comment.
Before this merges in, we'll want to attach any spreadsheets and supporting documents to archive things.
…HPXML into ghp_standard_improvements
…Rockies/OpenStudio-HPXML into ghp_standard_improvements
…Rockies/OpenStudio-HPXML into ghp_standard_improvements
…HPXML into ghp_standard_improvements
Collaborator
Author
I have added all my doc links to the PR description |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Update some comments, regenerate coefficients with small adjustments, and more?
Latest curves generated from the spreadsheet tool:
WaterAir_PE_Heating_updated_Yueyue.xls
WaterAir_PE_Cooling_updated_Yueyue.xls
Raw data:
lc377-climatemaster-commercial-tranquility-20-single-stage-ts-series-water-source-heat-pump-submittal-set.pdf
lc377-climatemaster-commercial-tranquility-20-single-stage-ts-series-water-source-heat-pump-submittal-set.xlsx
Checklist
Not all may apply:
EPvalidator.sch) has been updatedopenstudio tasks.rb update_hpxmls)HPXMLtoOpenStudio/tests/test*.rband/orworkflow/tests/test*.rb)openstudio tasks.rb update_measureshas been run