Repository navigation
Removes Location input for tankless water heaters - #2291
Merged
Merged
Conversation
…heating boiler with tankless coil" water heater types; it does not affect the model.
…HPXML into tankless-wh-loc # Conflicts: # Changelog.md # HPXMLtoOpenStudio/measure.xml
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Conditional location documentation must remain because the input still affects auxiliary storage-tank losses and zone heat gains.
1 open issue
What changed in this PR
This PR addresses #2290 by removing tankless water-heater Location entries from documented inputs and sample files, with no intended simulation changes.
Changes:
- Removes location entries from tankless samples and deletes two outside-location variants.
- Updates sample generation inputs and removes location assertions from water-heater tests.
- Updates input documentation, the changelog, and measure metadata.
| File | Description |
|---|---|
| workflow/sample_files/base-dhw-tankless-propane.xml | Removes tankless location. |
| workflow/sample_files/base-dhw-tankless-gas.xml | Removes tankless location. |
| workflow/sample_files/base-dhw-tankless-gas-with-solar.xml | Removes location from solar-assisted sample. |
| workflow/sample_files/base-dhw-tankless-gas-with-solar-fraction.xml | Removes location from solar-fraction sample. |
| workflow/sample_files/base-dhw-tankless-gas-ef.xml | Removes location from gas EF sample. |
| workflow/sample_files/base-dhw-tankless-electric.xml | Removes tankless location. |
| workflow/sample_files/base-dhw-tankless-electric-outside.xml | Deletes outside-location sample. |
| workflow/sample_files/base-dhw-tankless-electric-ef.xml | Removes location from electric EF sample. |
| workflow/sample_files/base-dhw-tankless-detailed-setpoints.xml | Removes location from detailed-setpoint sample. |
| workflow/sample_files/base-dhw-multiple.xml | Removes locations from tankless heaters. |
| workflow/sample_files/base-dhw-desuperheater-tankless.xml | Removes location from desuperheater sample. |
| workflow/sample_files/base-dhw-combi-tankless.xml | Removes tankless-coil location. |
| workflow/sample_files/base-dhw-combi-tankless-outside.xml | Deletes outside-location sample. |
| workflow/sample_files/base-bldgtype-mf-whole-building-fuels.xml | Removes tankless locations across dwelling units. |
| workflow/sample_files/base-bldgtype-mf-unit-shared-boiler-only-baseboard-combi-tankless.xml | Removes shared-boiler tankless-coil location. |
| workflow/hpxml_inputs.json | Clears inherited locations and removes deleted samples. |
| tasks.rb | Aligns sample-generation customizations. |
| HPXMLtoOpenStudio/tests/test_water_heater.rb | Removes tankless ambient-zone assertions. |
| HPXMLtoOpenStudio/measure.xml | Refreshes version metadata and test checksum. |
| docs/source/workflow_inputs.rst | Removes tankless location rows and footnotes. |
| Changelog.md | Records the input removal. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Closes #2290. Removes
Locationinput for "instantaneous water heater" and "space-heating boiler with tankless coil" water heater types.No simulation diffs expected.
Checklist
Not all may apply:
EPvalidator.sch) has been updatedopenstudio tasks.rb update_hpxmls)HPXMLtoOpenStudio/tests/test*.rband/orworkflow/tests/test*.rb)openstudio tasks.rb update_measureshas been run